Community
Participate
Working Groups
As discussed with several people on EclipseCon Europe we should use a better color color for DnD of Views and the toolbar. @Eric, can you give a tip where this color is defined?
+1! See 393454 comment 0.
Information for people which would like to help: org.eclipse.e4.ui.workbench.addons.dndaddon.DnDAddon from the org.eclipse.e4.ui.workbench.addons.swt plug-in would be the starting point. The corresponding Git repo is git://git.eclipse.org/gitroot/platform/eclipse.platform.ui.git See http://www.vogella.com/articles/Gerrit/article.html#eclipsegerritcontribution for the description how to clone the Eclipse UI platform Git repo and how to provide a Gerrit patch.
I think for Kepler the default color is White. At least for my Kepler it is. Also the color is defined in DnDManager#hostElement but I'm not completely sure about this one.
Created attachment 237148 [details] screenshot of DND as it looks on Linux (green) (In reply to Sopot Cela from comment #3) > I think for Kepler the default color is White. At least for my Kepler it is. > Also the color is defined in DnDManager#hostElement but I'm not completely > sure about this one. It's not white here, see the screenshot.
(In reply to Robin Stocker from comment #4) > Created attachment 237148 [details] > screenshot of DND as it looks on Linux (green) > > (In reply to Sopot Cela from comment #3) > > I think for Kepler the default color is White. At least for my Kepler it is. > > Also the color is defined in DnDManager#hostElement but I'm not completely > > sure about this one. > > It's not white here, see the screenshot. Yeah I completely forgot I always install a custom theme https://github.com/jeeeyul/eclipse-themes .
Created attachment 237151 [details] Red feedback overlay Turns out I was wrong on both remarks. The color of the drag feedback is set in the SplitFeedbackOverlay class in the setFeedback method. In that method there is a reference to the "DragFeedback" css element which is defined in the e4_basestyle.css in the org.eclipse.platform project. It's pretty trivial to change so as long as we settle for a color patch is ready. I attached a modified screenshot. Also the toolbar's drag color is defined in TrimDropAgent.
How about the selection color (e.g. blue on most platforms, or orange on Ubuntu): .DragFeedback { background-color: COLOR-LIST-SELECTION; } In addition to this, we could make it half-transparent using `feedbackShell.setAlpha(127);` in SplitFeedbackOverlay. TrimDropAgent can not be made transparent, right?
> .DragFeedback { > background-color: COLOR-LIST-SELECTION; > } Gerrit review to change the DnDColor to COLOR-LIST-SELECTION, thanks Robin and Sopot. https://git.eclipse.org/r/18015
(In reply to Lars Vogel from comment #8) > > .DragFeedback { > > background-color: COLOR-LIST-SELECTION; > > } > > Gerrit review to change the DnDColor to COLOR-LIST-SELECTION, thanks Robin > and Sopot. > > https://git.eclipse.org/r/18015 This is better than the green but - at least the bright blue on Windows 7 - is still way too glaring.
> > https://git.eclipse.org/r/18015 > > This is better than the green but - at least the bright blue on Windows 7 - > is still way too glaring. Could you attach a screenshot how it looks on Windows? I have no machine to test this on for MS.
Created attachment 237171 [details] Drag with selection color on Windows 7
How about a simple gray value?
(In reply to Sopot Cela from comment #12) > How about a simple gray value? Yes, similar to 3.x.
(In reply to Dani Megert from comment #13) > (In reply to Sopot Cela from comment #12) > > How about a simple gray value? Feel free to push an update to the review. Use the same Gerrit ID to update the existing one.
(In reply to Sopot Cela from comment #12) > How about a simple gray value? Yes, and make it a bit transparent, see comment 7.
(In reply to Robin Stocker from comment #15) > (In reply to Sopot Cela from comment #12) > > How about a simple gray value? > > Yes, and make it a bit transparent, see comment 7. I updated the review using light gray. Looks good on Ubuntu, can someone test on Windows? The SWT.COLOR-GRAY constant looked a bit strong IMHO. I think with "light gray" transparency would be an overkill, but I'm curious to hear other options.
I like the example that Dani posted, at least for the 'color' themes... IMO, 'gray' is pretty 80's...;-)
(In reply to Eric Moffatt from comment #17) > I like the example that Dani posted, at least for the 'color' themes... Well, that's a bad example actually. It is too eye-catching for a DnD feedback,and, at least on Windows 7, it is not the same as the native DnD feedback you see when e.g. dragging files: there you also get the same gray,pixelled look as we had in 3.x.
(In reply to Dani Megert from comment #18) > (In reply to Eric Moffatt from comment #17) > > I like the example that Dani posted, at least for the 'color' themes... > > Well, that's a bad example actually. It is too eye-catching for a DnD > feedback,and, at least on Windows 7, it is not the same as the native DnD > feedback you see when e.g. dragging files: there you also get the same > gray,pixelled look as we had in 3.x. (In reply to Eric Moffatt from comment #17) > I like the example that Dani posted, at least for the 'color' themes... > > IMO, 'gray' is pretty 80's...;-) I agree with Dani that the blue is pretty ugly and strong on Windows. Dani, what do you think about the light gray?
(In reply to Lars Vogel from comment #19) > (In reply to Dani Megert from comment #18) > > (In reply to Eric Moffatt from comment #17) > > > I like the example that Dani posted, at least for the 'color' themes... > > > > Well, that's a bad example actually. It is too eye-catching for a DnD > > feedback,and, at least on Windows 7, it is not the same as the native DnD > > feedback you see when e.g. dragging files: there you also get the same > > gray,pixelled look as we had in 3.x. > > (In reply to Eric Moffatt from comment #17) > > I like the example that Dani posted, at least for the 'color' themes... > > > > IMO, 'gray' is pretty 80's...;-) > > I agree with Dani that the blue is pretty ugly and strong on Windows. > > Dani, what do you think about the light gray? See my comment in the Gerrit change.
> See my comment in the Gerrit change. Thanks. Gerrit review adjust to your comments.
(In reply to Lars Vogel from comment #21) > > See my comment in the Gerrit change. > > Thanks. Gerrit review adjust to your comments. Thanks Lars! Submitted with http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=df5cf92b730772c5ca45868d2477050c11cbb8f2
> Thanks Lars! Submitted with > http://git.eclipse.org/c/platform/eclipse.platform.git/commit/ > ?id=df5cf92b730772c5ca45868d2477050c11cbb8f2 Thanks you Dani for the merge and the active feedback on the suggest change. It is just a small change but I think our users will like the new DnD color.
While this is still hot can we also change the color of toolbar drag? A (light) gray would make sense also I think. Seeing plain green when you start the drag doesn't look good to my eye at least.
(In reply to Sopot Cela from comment #24) > While this is still hot can we also change the color of toolbar drag? A > (light) gray would make sense also I think. Seeing plain green when you > start the drag doesn't look good to my eye at least. Please file a new bug. This is easier to track.
.
(In reply to Dani Megert from comment #25) > (In reply to Sopot Cela from comment #24) > > While this is still hot can we also change the color of toolbar drag? A > > (light) gray would make sense also I think. Seeing plain green when you > > start the drag doesn't look good to my eye at least. > > Please file a new bug. This is easier to track. Oh, I see, this is about the same "green" issue. And Lars already provided a patch that I submitted: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b2eb153ae57dd6cb437dc03921ce0ee23affdf70
My bad then. Thanks Lars.
*** Bug 421072 has been marked as a duplicate of this bug. ***
Verified in Build id: I20131211-2000
