Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 420742 - [KeyBindings] Key Assist popup doesn't work for most commands
Summary: [KeyBindings] Key Assist popup doesn't work for most commands
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.3.2   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 420722
Blocks:
  Show dependency tree
 
Reported: 2013-10-30 12:03 EDT by Dani Megert CLA
Modified: 2014-01-06 04:45 EST (History)
4 users (show)

See Also:
markus.kell.r: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2013-10-30 12:03:34 EDT 
+++ This bug was initially created as a clone of Bug #420722 +++

The Key Assist popup is broken for most commands.

It only seems to work for commands in the "In Windows" context that don't care about what shell has focus (e.g. About or Show View).

But for most of the commands, a correct implementation must first close the popup and only then execute the command.

Fixing this bug would probably also solve bug 369860.
Comment 2 Markus Keller CLA 2013-11-04 11:56:32 EST 
(In reply to Dani Megert from comment #0)
> Fixing this bug would probably also solve bug 369860.

As found in bug 420722 comment 2, this fix doesn't affect bug 369860.
This bug is only about the "big" Help > Key Assist... (Ctrl+Shift+L) command.

Fix from comment 1 is good.
Comment 4 Paul Webster CLA 2013-11-29 09:54:11 EST 
In 4.3.0.M20131127-1300  On linux this fix doesn't work for me.

1) activate the package explorer
2) CTRL+SHIFT+L
3) select activate editor

The package explorer is still the active part.

1) activate an editor
2) place the cursor in middle of a line
3) CTRL+SHIFT+L
4) select Line End

The cursor is still in the middle of the line.

PW
Comment 5 Dani Megert CLA 2013-12-04 08:46:50 EST 
(In reply to Paul Webster from comment #4)
> In 4.3.0.M20131127-1300  On linux this fix doesn't work for me.
> 
> 1) activate the package explorer
> 2) CTRL+SHIFT+L
> 3) select activate editor
> 
> The package explorer is still the active part.
> 
> 1) activate an editor
> 2) place the cursor in middle of a line
> 3) CTRL+SHIFT+L
> 4) select Line End
> 
> The cursor is still in the middle of the line.
> 
> PW

I verified on Ubuntu that my fix worked in 4.4 M3 and also M20131106-0800 when it went into the maintenance branch. BUT: some other change(s) that got committed into maintenance and also master broke this on Linux only. Argh!

Investigating...
Comment 6 Dani Megert CLA 2013-12-04 09:30:19 EST 
(In reply to Dani Megert from comment #5)
> Investigating...

The fix for bug 412001 causes this. I suggest to revert that change given that a broken Key Assist dialog is much more severe than bug 412001.

PaulE and PaulW, any objection? Or do you want to investigate it in more detail? We should do this before M4 next week. Thanks!
Comment 7 Paul Elder CLA 2013-12-04 09:48:34 EST 
(In reply to Dani Megert from comment #6)
> (In reply to Dani Megert from comment #5)
> > Investigating...
> 
> The fix for bug 412001 causes this. I suggest to revert that change given
> that a broken Key Assist dialog is much more severe than bug 412001.
> 
> PaulE and PaulW, any objection? Or do you want to investigate it in more
> detail? We should do this before M4 next week. Thanks!

Go ahead. I was suspicious that the fix was too easy/simple.
Comment 8 Dani Megert CLA 2013-12-04 11:24:32 EST 
(In reply to Paul Elder from comment #7)
> > PaulE and PaulW, any objection? Or do you want to investigate it in more
> > detail? We should do this before M4 next week. Thanks!
> 
> Go ahead. I was suspicious that the fix was too easy/simple.

Thanks Paul!
Comment 9 Dani Megert CLA 2014-01-06 04:45:12 EST 
Verified in M20131218-0800.