This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 420722 - [KeyBindings] Key Assist popup doesn't work for most commands
Summary: [KeyBindings] Key Assist popup doesn't work for most commands
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.4 M3   Edit
Assignee: Dani Megert CLA
QA Contact: Paul Elder CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 420742
  Show dependency tree
 
Reported: 2013-10-30 09:41 EDT by Markus Keller CLA
Modified: 2013-11-04 08:53 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2013-10-30 09:41:24 EDT 
The Key Assist popup is broken for most commands.

It only seems to work for commands in the "In Windows" context that don't care about what shell has focus (e.g. About or Show View).

But for most of the commands, a correct implementation must first close the popup and only then execute the command.

Fixing this bug would probably also solve bug 369860.
Comment 2 Dani Megert CLA 2013-10-30 12:10:11 EDT 
The fix does not help with bug 369860.

Filed bug 420742 to backport this to 4.3.2.
Comment 3 Paul Webster CLA 2013-10-30 17:04:18 EDT 
In 4.4.0.I20131030-1400

I tested the key assist dialog with commands like Run Junit Plug-in Test and Line End.  They seemed to work correctly in the workbench window.

PW
Comment 4 Dani Megert CLA 2013-11-04 08:53:47 EST 
(In reply to Dani Megert from comment #1)
> This is also broken in 4.3.x.
> 
> Fixed with
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=http://
> git.eclipse.org/c/jdt/eclipse.jdt.ui.git/

Wrong URL. Correct is:
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6c07c2033e1be50f163a326e31609d9d4323b4b6