Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 420458 - [1.8][dom ast] JLS8 ASTParser gives up on multi-dimensional array reference in Javadoc
Summary: [1.8][dom ast] JLS8 ASTParser gives up on multi-dimensional array reference i...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: BETA J8   Edit
Assignee: Manoj N Palat CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-27 13:57 EDT by Markus Keller CLA
Modified: 2014-01-12 02:27 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2013-10-27 13:57:54 EDT 
BETA_JAVA8

For JLS8, the ASTParser gives up on multi-dimensional array references in a MethodRefParameter and leaves the whole Javadoc node without any children. Still Works fine for JLS4.

/**
 * Hello.
 * @see #foo(Object[][][])
 */
Comment 1 Markus Keller CLA 2013-10-27 15:17:45 EDT 
I needed this to continue, so I just fixed it with http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=071c3a7154f042f1dac67e366b91c1f1b510f2e9

I've also fixed the missing argument.setVarargs(isVarargs) to make the AST consistent. (Caveat: The Javadoc spec doesn't mention support for varargs in Javadoc method references. Feature: javadoc.exe supports varargs as long as the type is not an array type. ecj follows javadoc.exe.)

Would be good to have a regression test as well.
Comment 2 Markus Keller CLA 2013-10-27 16:53:24 EDT 
First fix broke ASTs < JLS8. Fixed with http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=db9f959a935f205a7a7a5ac245a707865595ee87
Comment 4 Srikanth Sankaran CLA 2014-01-10 20:48:00 EST 
(In reply to Manoj Palat from comment #3)
> Added the testcases via commit:
> http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/
> ?h=BETA_JAVA8&id=4605f993bb123a9187b7d6cf100f3cd705b1424a


This generates a new compile time warning, please fix.
Comment 5 Manoj N Palat CLA 2014-01-12 02:27:08 EST 
(In reply to Srikanth Sankaran from comment #4)

> This generates a new compile time warning, please fix.
Thanks Srikanth. Fixed via http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?h=BETA_JAVA8&id=2c7a59198ef0accc78a3ea8fb276fbfe877a83c2