Community
Participate
Working Groups
I20030826-rebuild
I20030826-200308261317: Key Bindings preference dialog doesn't work. This is a major regression w.r.t I20030820 and must not go into M3.
*** This bug has been marked as a duplicate of 42042 ***
My mistake - typed a PR number in the wrong field
re: Keys Preference Page Yes there are changes here. In fact, its brand new code to work with the new commands API. Brand new unfinished code, unfortunately. Of course, its only 10:33 EST and i have until 3pm! This new build is currently missing the following features 1. commands combo not filtering/changing in sync with category combo (FIXED) 1. visual indication of assignments of commands to key sequence (table is empty) 2. visual indication of assignments of key sequences to command (table is empty) 3. allowing selection of the items in the above tables to change the selction of the combo boxes. 4. proper enabled/disable states for the add, remove, and restore buttons. believe it or not, however, it does work correctly in terms of adding and removing keybindings. though without 1 and 2 you are flying blind right now.
whoops the numbering was wrong.. i meant 1,2,3,4, and 5, of course. 1,2, and 4 is fixed. 5 is unchanged, but may not be required. 3 is not finished, but is not essential for M3 (having point 2 fixed covers the essentials of visual indication of assignments)
Are you saying 2. as shown in your initial list is fixed? When I select a command I still don't see which key it is bound to. I think the following are not working in the 0827 build: 1. visual indication of assignments of commands to key sequence (table is empty) 2. allowing selection of the items in the above tables to change the selction of the combo boxes. 3. proper enabled/disable states for the add, remove, and restore buttons.
I was able to reassign some shortcuts. Here my other impressions: - it's cool that I can enter a shortcut using modifiers and see the assigned command(s) - before I noticed the coolness I tried to enter the shortcut via character keys and not using modifiers. After entering Ctrl (which appeared as "CTRL") I was not able to enter the "+" and I did not get any feedback that would bring me on the right track - with the new UI it is harder to get an overview of the available commands. This was easier with tree than with the two drop downs.
to knut: i should not be allowed to number things. it causes too much confusion. the table of command assigned to a particular key sequence (the top table) works, the inverse view (the bottom table), does not. selection should work correctly on the top table. to daniel: re entering key sequences: yes, perhaps a text on the dialog that tells the user to enter the key sequence directly, which perhaps throws up a warning icon and alters the text somewhat when the user types in unmodified characters. (people wouldn't intend to bind to a single unmodified letter for instance; that letter would be unusable in the editors.) re: tree vs. dropdowns: this was a concerted effort to reduce the size of the keys preference page, which i believe had the dubious distinction of being the largest preference page in the 2.1 release. (currently, on the mac at least, i'm a fair bit smaller than java editor pref page.. :)
to knut again: sorry, you are right selection of the top table doesn't completely work. it does select the context ("When") correctly, but never changes the category or command combo boxes.
May i dissent on the choice of drop down menus vs tree view? I completely agree with Daniel Megert, there are so many choices for categories and names within them that unless you have the keys tree well cast in your mind, like perhaps you developers have, finding an action without knowing in advance to which category it belongs, is a real pain. And not speaking of the fact that the tree view was giving an immediate grasp of all the keys mapping organization. In a few words i find this page really unfriendly at best and i'd rather vote to have back the old tree view.
major issues fixed. i am resolving (the remaining issues) in this pr as a duplicate of 43506. i've annotated 43506 with your outstanding concerns. thanks *** This bug has been marked as a duplicate of 43506 ***
