Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 419926 - References to Viewpoint as a concept should not have been renamed into Sirius
Summary: References to Viewpoint as a concept should not have been renamed into Sirius
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 trivial (vote)
Target Milestone: 0.9   Edit
Assignee: Project inbox CLA
QA Contact: Maxime Porhel CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-20 08:20 EDT by Felix Dorner CLA
Modified: 2016-01-28 04:05 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Dorner CLA 2013-10-20 08:20:27 EDT 
Just a typo that could be corrected.
Comment 1 Alex Lagarde CLA 2013-10-20 09:15:54 EDT 
Actually this should be ViewpointSelection.openViewpointSelectionDialog(), this is our migration tool that went one step to far while renamming.
Comment 2 Pierre-Charles David CLA 2013-10-20 10:26:58 EDT 
Thanks for the feedback.

Fixed (along with several other instances in the same type) by http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2e579aa0caaac213f14be2e0140ae4fe1e00a7bb.

As Alex mentioned this is an artefact of the "rebranding" process we applied on the previous code base: the system used to be called "Viewpoint" instead of "Sirius", but "Viewpoint" is also the name of a central concept. When renaming into Sirius, many instances of "Viewpoint the concept" were (incorrectly) renamed into "Sirius".

I'm leaving the bug opened and changing its title into something more general so that we can use it to reference the other commits related to this rebranding issue (we have already fixed some, but we know many remains).
Comment 3 Maxime Porhel CLA 2013-11-06 10:37:20 EST 
I found some other entries wich should not have been renamed into Sirius. 

Two of them might be discussed: Viewpoint Specification Model and Viewpoint Specification Project (and associated icons, wizards, properties, doc entries). See Gerrit review https://git.eclipse.org/r/#/c/18140/
Comment 4 Maxime Porhel CLA 2013-11-07 04:04:45 EST 
Several SiriusURI occurences can still be found (46 matches with file search), they should be renamed to ViewpointURI.
Comment 5 Maxime Porhel CLA 2013-11-07 04:09:37 EST 
"Siriuss" occurences should be renamed into "Viewpoints".
Comment 6 Pierre-Charles David CLA 2013-12-06 09:46:55 EST 
Closing this for 0.9.0. There are certainly more instances where the names are wrong, but I think the vast majority are OK now. The remaining cases will be handled when we stumble on them.
Comment 7 Maxime Porhel CLA 2013-12-10 04:31:24 EST 
Verified on 0.9.0.201312100846 build.
Comment 8 Maxime Porhel CLA 2013-12-11 11:42:00 EST 
Released in Sirius 0.9.0
Comment 9 Nathalie Lepine CLA 2014-08-28 04:34:16 EDT 
UserSession.from(newSession).selectViewpoint("XXX"); 
renamed in
UserSession.from(newSession).selectSirius("XXX");

same thing for selectOnlySirius and findSiriusByName
Comment 10 Maxime Porhel CLA 2014-08-28 08:32:00 EDT 
Wrong rebrandings in UserSession have been corrected for on master (for 2.0.0) by commit 5068a5ed4bd25762863295dfbe1819041652addf (see corresponding review: https://git.eclipse.org/r/#/c/32466/)