Community
Participate
Working Groups
See bug 419030 attachment 236495 [details]. I'll be addressing the about.mappings (eventually), but PDE ends up with one "dirty jar" after a build. If the jar listed is intended to be part of the build, they need to be in target (and, only in target) instead of "in working tree". If they are not intended to be "part of the build", they should be marked in .gitignore ... if produced at all. We may need to address this before moving up to Tycho 0.19, so would appreciate a quick assessment if "fixable" in next week or two (before M3) or if will be more complicated and would take longer (which is fine, if it does ... just taking a poll). = = = = = = Entering 'eclipse.pde.ui' # On branch master # Changes not staged for commit: # (use "git add <file>..." to update what will be committed) # (use "git checkout -- <file>..." to discard changes in working directory) # # modified: ui/org.eclipse.pde/about.mappings # # Untracked files: # (use "git add <file>..." to include in what will be committed) # # ui/org.eclipse.pde.ui.tests/tests.jar no changes added to commit (use "git add" and/or "git commit -a") = = = =
I do not know why the test binary output is put into a named library (tests.jar) over the root. Just peeking at jdt.debug I see a similar setup. It has been set up this way for longer than my involvement in PDE (2004). I can add it to the gitignore or we can try changing the test setup, though I would prefer to not break everything :)
(In reply to Curtis Windatt from comment #1) > I do not know why the test binary output is put into a named library > (tests.jar) over the root. Just peeking at jdt.debug I see a similar setup. > It has been set up this way for longer than my involvement in PDE (2004). > > I can add it to the gitignore or we can try changing the test setup, though > I would prefer to not break everything :) Yeah, I noticed similar thing as I looked at bug 419522. My preference would be for people to try and put .class files in the root of the bundle, since that's the "modern" OSGi way of doing things ... but, admit, there is a little more risk with that. And think there is zero risk with adding it to .gitignore, in that bundle ... so anyone with limited interest/time should probably go the .gitignore route (though I am going to try to "flatten" the ones in bug 419522 ... knowing I may have to revert and use .gitignore anyway. I do see for org.eclipse.pde.ui.tests, that the old .cvsignore had "tests.jar" in it ... so all the more reason for you to add to a .gitignore file there.
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=5afedba43b7360d5eb1049226148ace7fe32bda5 Added gitignore, hopefully it doesn't break anything in the next build :)
Looks like this got fixed a while ago.
