This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 419435 - [Themes] Invalid RGB color value in themes extension makes workbench unusable
Summary: [Themes] Invalid RGB color value in themes extension makes workbench unusable
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M3   Edit
Assignee: Christian Georgi CLA
QA Contact: Daniel Rolka CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-15 05:32 EDT by Christian Georgi CLA
Modified: 2014-06-04 08:11 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Georgi CLA 2013-10-15 05:32:26 EDT 
A single invalid RGB color value in a "org.eclipse.ui.themes" extension leads to the workbench not starting up correctly.  Afterwards it basically unusable.

java.lang.IllegalArgumentException: Argument not valid
	at org.eclipse.swt.SWT.error(SWT.java:4378)
	at org.eclipse.swt.SWT.error(SWT.java:4312)
	at org.eclipse.swt.SWT.error(SWT.java:4283)
	at org.eclipse.swt.graphics.RGB.<init>(RGB.java:76)
	at org.eclipse.jface.resource.StringConverter.asRGB(StringConverter.java:565)
	at org.eclipse.ui.themes.ColorUtil.getColorValue(ColorUtil.java:175)
	at org.eclipse.ui.internal.themes.ColorDefinition.getValue(ColorDefinition.java:157)
	at org.eclipse.ui.internal.themes.ThemeElementHelper.installColor(ThemeElementHelper.java:284)
	at org.eclipse.ui.internal.themes.ThemeElementHelper.populateRegistry(ThemeElementHelper.java:172)
	at org.eclipse.ui.internal.Workbench$28.runWithException(Workbench.java:1664)
	at org.eclipse.ui.internal.StartupThreading$StartupRunnable.run(StartupThreading.java:31)
	at org.eclipse.swt.widgets.Synchronizer.syncExec(Synchronizer.java:180)
	at org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:150)
	at org.eclipse.swt.widgets.Display.syncExec(Display.java:4688)
	at org.eclipse.ui.internal.StartupThreading.runWithoutExceptions(StartupThreading.java:94)
	at org.eclipse.ui.internal.Workbench.initializeApplicationColors(Workbench.java:1659)
	at org.eclipse.ui.internal.Workbench.init(Workbench.java:1553)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2702)
	at org.eclipse.ui.internal.Workbench.access$7(Workbench.java:2591)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:608)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
...
Comment 1 Christian Georgi CLA 2013-10-15 05:40:07 EDT 
Patch: https://git.eclipse.org/r/#/c/17375/
Comment 3 Dani Megert CLA 2013-10-15 11:07:27 EDT 
FYI: I've added your credentials to the copyright notice.
Comment 4 Daniel Rolka CLA 2014-06-04 08:11:41 EDT 
Verified in the build: 4.4RC3

Daniel