This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 418664 - Get rid of compile warnings in official build
Summary: Get rid of compile warnings in official build
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M3   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-04 06:03 EDT by Dani Megert CLA
Modified: 2013-10-08 03:39 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2013-10-04 06:03:50 EDT 
org.eclipse.core.runtime causes many compile warnings in official build
Comment 1 John Arthorne CLA 2013-10-04 15:58:40 EDT 
I'm not sure I got every one, but I took a stab at this for some late Friday afternoon fun:

http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=31d231e66c2153c781982346e03342ad94529dd6
Comment 2 Dani Megert CLA 2013-10-07 05:38:29 EDT 
(In reply to John Arthorne from comment #1)
> I'm not sure I got every one, but I took a stab at this for some late Friday
> afternoon fun:
> 
> http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/
> ?id=31d231e66c2153c781982346e03342ad94529dd6

The amount of warnings did not go down (still 104). It looks like just tried to ignore them by tweaking the project settings. However, those are not read by the builder. If you really want to ignore the problems instead of fixing them, then this needs to be done in the build.properties for PDE Build and in the POM for Tycho.
Comment 3 Dani Megert CLA 2013-10-07 06:12:30 EDT 
(In reply to Dani Megert from comment #2)
> (In reply to John Arthorne from comment #1)
> > I'm not sure I got every one, but I took a stab at this for some late Friday
> > afternoon fun:
> > 
> > http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/
> > ?id=31d231e66c2153c781982346e03342ad94529dd6
> 
> The amount of warnings did not go down (still 104).

Sorry John, other projects also have lots of more warnings again. I filed bug bug 418793 to track that.

Looking at N20131005-1500 only 2 warnings appear.
Comment 4 John Arthorne CLA 2013-10-07 10:24:22 EDT 
(In reply to Dani Megert from comment #3)
> Looking at N20131005-1500 only 2 warnings appear.

Actually Dani would you mind taking a quick look at this last one. It says both unnecessary @SuppressWarnings("unchecked"), and a warning saying I have an unchecked cast! There must be something I am misunderstanding about how @SuppressWarnings is scoped. The code is here (lines 266-268):

http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/tree/bundles/org.eclipse.core.runtime/src/org/eclipse/core/internal/runtime/AuthorizationHandler.java
Comment 5 Dani Megert CLA 2013-10-07 11:54:05 EDT 
(In reply to John Arthorne from comment #4)
> (In reply to Dani Megert from comment #3)
> > Looking at N20131005-1500 only 2 warnings appear.
> 
> Actually Dani would you mind taking a quick look at this last one. It says
> both unnecessary @SuppressWarnings("unchecked"), and a warning saying I have
> an unchecked cast! There must be something I am misunderstanding about how
> @SuppressWarnings is scoped. The code is here (lines 266-268):

It's scoped to the declaration.


Fixed with http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=fef422582be3393016e5221f366138ae7ff5f38f
Comment 6 Dani Megert CLA 2013-10-08 03:39:31 EDT 
Verified in N20131007-2000.