Community
Participate
Working Groups
In some cases, it makes sense to have the view where "Show In" is invoked as target in the "Show In" menu itself. One such case is in EGit with the history view. When viewing the changed files of a commit and there is a deleted file, one may want to view the history of that file before it was deleted. In that case, Show In > History would make sense, see bug 348601. In general, it doesn't make sense, but for specific cases, it would be nice if this could be requested. One way to do that would be to explicitly list the view in IShowInTargetList. But even then, the own view is currently filtered. The code which filters the targets is in ShowInMenu#getViewDescriptors. Moving it to getShowInPartIds would allow to change the behavior to only filter it before adding the targets from IShowInTargetList. I can provide a patch, but the question to answer before that is: Is this change in behavior acceptable?
This seems reasonable to me. If the part lists itself as a valid show in target we can respect that, but make sure we filter the part from the more generic page show in list. PW
Proposed fix: https://git.eclipse.org/r/17715
Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=501d695fdbc0f795e15b07b98659a220751dcf74 Thanks Robin, PW
In 4.4.0.I20131028-2000 PW
