Description Ben Cox 2013-09-26 07:11:06 EDT

I've just been trying to find an existing view with both a view and secondary ID. However, WorkbenchPage#findViewReference("my.view.id", "the.secondary.id") wasn't finding it.

I discovered that I had to call findViewReference("my.view.id:the.secondary.id", "the.secondary.id").

Further investigation shows that this is because findViewReference first performs the following check:

if (viewId.equals(reference.getId())) {...}

However, reference.getId() will return the view ID concatenated with a colon and the secondary ID, so won't match when only the view ID has been passed as the viewId parameter to the method.

Is this behaviour intended? Shouldn't this be separating the stored ID into view ID and secondary ID, and independently comparing them with the view ID and secondary ID parameters?