This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 418022 - [Contributions] Customize Perspective has hiding conflicts for toolbars and menus
Summary: [Contributions] Customize Perspective has hiding conflicts for toolbars and m...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.3.2   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on: 411577
Blocks: 420956
  Show dependency tree
 
Reported: 2013-09-25 09:58 EDT by Paul Webster CLA
Modified: 2014-02-21 07:51 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2013-09-25 09:58:38 EDT 
Backport to 4.3.2

+++ This bug was initially created as a clone of Bug #411577 +++

If a toolbar and a menu has the same id and both elements shell be hidden updateHiddenElements does not consider the prefix in its containment check. 
The outcome is that only one of the item (either a toolbar item or a menu item) may be hidden at a time.

The fix is trivial in adding the prefix to the contains check. Then both items may be hidden at a time.

Reproduction can be done by hiding the file menu and toolbar items
Comment 1 Paul Webster CLA 2013-11-18 15:17:11 EST 
Jens, could I get you to log into https://git.eclipse.org/r/#/ once (with your bugzilla email/password)?  That will allow me to patch back your fix.

PW
Comment 2 Paul Webster CLA 2013-11-18 15:17:57 EST 
The error I'm currently getting:



remote: Resolving deltas: 100% (7/7)
remote: Processing changes: refs: 1, done    
remote: ----------
remote: Reviewing commit: commit b5f7b69add5a6954e30e053aa836e6bbee4e5468 1384805499 ----sp
remote: Authored by: Jens übler <kuebler@aquintos.com>
remote: 
remote: error: The author does not have a Gerrit account.
remote: All authors must either be a commiter on the project, or have a current CLA on file.
remote: Please see http://wiki.eclipse.org/CLA
remote: 
To ssh://pwebster@git.eclipse.org:29418/platform/eclipse.platform.ui
 ! [remote rejected] HEAD -> R4_3_maintenance (The author must register with Gerrit.)
Comment 3 Jens Kuebler CLA 2013-11-19 03:30:20 EST 
done.
Comment 4 Paul Webster CLA 2013-11-19 13:12:24 EST 
backport: https://git.eclipse.org/r/18579

Thanks Jens
Comment 6 Paul Webster CLA 2013-11-29 10:25:30 EST 
In 4.3.0.M20131127-1300

PW
Comment 7 Martin Oberhuber CLA 2014-02-21 07:51:20 EST 
CQ:WIND00-WB4-2813