Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 417828 - incorrect i18n handling in pageLinksPlugin
Summary: incorrect i18n handling in pageLinksPlugin
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.0 RC1   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 387399 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-09-23 09:53 EDT by Mark Macdonald CLA
Modified: 2013-09-25 15:26 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2013-09-23 09:53:38 EDT 
pageLinksPlugin.js is trying to load message catalogs directly using the i18n loader plugin:

> define([
>     'i18n!orion/nls/messages'

This is invalid. Instead, the services need to specify an i18n bundle ("nls") and string id ("NameKey"). The Orion page needs to read those, fetch the bundle and grab the string from it.
Comment 1 Mark Macdonald CLA 2013-09-23 12:54:28 EDT 
Fixing this properly (ie. without regressing Bug 412524) will also fix bug 387399. Basically we need to add nls support to the plugin settings service API.
Comment 2 Mark Macdonald CLA 2013-09-23 12:54:57 EDT 
*** Bug 387399 has been marked as a duplicate of this bug. ***
Comment 3 Mark Macdonald CLA 2013-09-25 15:26:48 EDT 
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=00c3f4f
Added support for translating plugin settings.