This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 417213 - [Perspectives] Sash layout corrupted by dragging into the editor area
Summary: [Perspectives] Sash layout corrupted by dragging into the editor area
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.3.2   Edit
Assignee: Wojciech Sudol CLA
QA Contact: Wojciech Sudol CLA
URL:
Whiteboard:
Keywords:
Depends on: 417201
Blocks:
  Show dependency tree
 
Reported: 2013-09-13 13:12 EDT by Eric Moffatt CLA
Modified: 2013-11-29 07:39 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2013-09-13 13:12:53 EDT 
+++ This bug was initially created as a clone of Bug #417201 +++

Found this testing the DnD behavior. When you drag a view into the shared area you get two different affordances; 50/50 and 34/66 depending how close to the edge of the shared area you are.

If you drop when the rectangles are the same size then the shared area shrinks to zero width.

The is the result of the attempt of a new sash to 'adopt' the containerData (weight) of the shared area being done in the wrong place, *after* the sash is added into the model (and given a default value).
Comment 1 Eric Moffatt CLA 2013-09-13 13:14:00 EDT 
This is a candidate for 4.3.2 mostly because the fix is simple and the issue highly visible once hit...
Comment 2 Wojciech Sudol CLA 2013-11-20 07:47:06 EST 
Review URL: https://git.eclipse.org/r/#/c/18609/
Contains exact copy of changes from the commit for the bug 417201:
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=fd8f820427b861f2863ad9e409f8ec724579f77a
Comment 4 Dani Megert CLA 2013-11-20 10:38:46 EST 
Fix forgot to increase bundle version of 'org.eclipse.e4.ui.workbench.addons.swt'.

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6c4e3cfccb141a2f004e7125ec01e4edfa288c27
Comment 5 Wojciech Sudol CLA 2013-11-29 07:39:14 EST 
Verified in M20131127-1300.