This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 417212 - [Perspectives] CTabFolder layouts content too often / too many of them
Summary: [Perspectives] CTabFolder layouts content too often / too many of them
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.3.2   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on: 416650
Blocks: 427133
  Show dependency tree
 
Reported: 2013-09-13 13:10 EDT by Eric Moffatt CLA
Modified: 2014-02-03 06:10 EST (History)
11 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2013-09-13 13:10:30 EDT 
+++ This bug was initially created as a clone of Bug #416650 +++

There are multiple problems with CTabFolder leading to preformance problems:
a) if a layout is triggered it also layouts all its children even those tabs who 
   are not active
b) each time a Tab is selected

This leads to bad performance on Eclipse 4 applications e.g. when dragging sashes, ... .

A layout should only be triggered when really needed e.g. the size changed since last time a layout has been done.
Comment 1 Eric Moffatt CLA 2013-09-13 13:12:25 EDT 
Here's the 4.3.2 version of the defect. Since we have time I'd like to let the Luna version of the fix soak for at least until the end om M3 in case anything comes up.

It's a 4.3.2 candidate because it has significant performance impact...
Comment 2 Eric Moffatt CLA 2013-12-20 13:06:32 EST 
Here's the Gerrit:

  https://git.eclipse.org/r/20126

PW, I'll add you as a reviewer...
Comment 4 Eric Moffatt CLA 2014-01-30 14:26:21 EST 
Verified in 4.3.2.M20140129-0800.
Comment 5 Paul Webster CLA 2014-02-03 06:10:36 EST 
It appears this change causes bug 427133