This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 417201 - Sash layout corrupted by dragging into the editor area
Summary: Sash layout corrupted by dragging into the editor area
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M2   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 417213
  Show dependency tree
 
Reported: 2013-09-13 11:10 EDT by Eric Moffatt CLA
Modified: 2013-09-16 10:51 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2013-09-13 11:10:35 EDT 
Found this testing the DnD behavior. When you drag a view into the shared area you get two different affordances; 50/50 and 34/66 depending how close to the edge of the shared area you are.

If you drop when the rectangles are the same size then the shared area shrinks to zero width.

The is the result of the attempt of a new sash to 'adopt' the containerData (weight) of the shared area being done in the wrong place, *after* the sash is added into the model (and given a default value).
Comment 1 Eric Moffatt CLA 2013-09-13 11:12:17 EDT 
To reproduce just start with the java perspective and drag the Problems view into the shared area to split it *vertically* when the rects are the same size...
Comment 2 Eric Moffatt CLA 2013-09-13 11:37:04 EDT 
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=fd8f820427b861f2863ad9e409f8ec724579f77a

Move the code to maintain the sash weight into the model service where it creates the new sash...
Comment 3 Eric Moffatt CLA 2013-09-16 10:51:46 EDT 
Verified in 4.4.0.I20130915-2000.