This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 416995 - [Code review] The "perspective" string should be turned into a constant on E4Application
Summary: [Code review] The "perspective" string should be turned into a constant on E4...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M2   Edit
Assignee: Daniel Rolka CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-11 06:25 EDT by Daniel Rolka CLA
Modified: 2013-09-18 08:16 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Rolka CLA 2013-09-11 06:25:50 EDT 

    


    


      



        
          Comment 1
        

        
          Daniel Rolka CLA

        

        
        

        
          2013-09-11 06:28:57 EDT
        

      






Apply the Gerrit review comment from bug 377981 related to the change in the file: bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/E4Application.java

See the Gerrit review: https://git.eclipse.org/r/#/c/13052/ (Patch Set 8)

    


    


      



        
          Comment 2
        

        
          Paul Webster CLA

        

        
        

        
          2013-09-12 08:52:43 EDT
        

      






Daniel, please remember to include the Gerrit Review URL in the bugs: https://git.eclipse.org/r/#/c/16352/

Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=087a045bec3db62fffbaa659f2592f31d497085e

PW

    


    


      



        
          Comment 3
        

        
          Eric Moffatt CLA

        

        
        

        
          2013-09-16 10:53:12 EDT
        

      






Verified (visually) in 4.4.0.I20130915-2000.

    


    


      



        
          Comment 4
        

        
          Dani Megert CLA

        

        
        

        
          2013-09-18 08:16:20 EDT
        

      






(In reply to Paul Webster from comment #2)
> Daniel, please remember to include the Gerrit Review URL in the bugs:
> https://git.eclipse.org/r/#/c/16352/

And please add the change id to the commit message:
Change-Id: I087a045bec3db62fffbaa659f2592f31d497085e