Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 416956 - [server] Some tests that extend FileSystemTest fail when when orion.file.layout=userTree
Summary: [server] Some tests that extend FileSystemTest fail when when orion.file.layo...
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Server (show other bugs)
Version: 4.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.0 M2   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 412995
  Show dependency tree
 
Reported: 2013-09-10 14:32 EDT by Anthony Hunter CLA
Modified: 2013-09-10 16:30 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Hunter CLA 2013-09-10 14:32:10 EDT 
The same issue as Bug 416952
	
The default project layout on the Orion server is flat but you can optionally set the value orion.file.layout=userTree to turn on organizing the layout of the projects. The orion.eclipse.org server is using userTree.

When you add this setting to an orion.conf on a server against which the JUnit tests are run, many of the test that extend FileSystemTest fail.

The problem is in the makeLocalPathAbsolute() and remove() methods.

Both make the assumption that the project folder on physical disk is ${orion.home}/${project} , which is true for flat but not userTree. 

Both need to get the correct value using OrionConfiguration.getUserHome(), whose value is dependent on the setting of orion.file.layout.