This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 416954 - -perspective at product program arguments is not working in 4.2M6
Summary: -perspective at product program arguments is not working in 4.2M6
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.3.2   Edit
Assignee: Daniel Rolka CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 377981
Blocks:
  Show dependency tree
 
Reported: 2013-09-10 14:24 EDT by Paul Webster CLA
Modified: 2013-11-04 15:16 EST (History)
10 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2013-09-10 14:24:28 EDT 
Backport fix to 4.3.2

+++ This bug was initially created as a clone of Bug #377981 +++

Build Identifier: 4.2 M6

The program arguments of the product configuration of my project has this: -perspective myDefaultPerspective

But after start the runtime the perspective that appears is Resource.

This works properly in Eclipse Indigo.

Reproducible: Always

Steps to Reproduce:
1. create a product configuration and add -perspective <your perspective>
2. use as product: org.eclipse.platform.ide
3. use as Application: org.eclipse.ui.ide.workbench
Comment 1 Daniel Rolka CLA 2013-09-12 09:05:32 EDT 
Gerrit review link: https://git.eclipse.org/r/#/c/16351/
Comment 2 Dani Megert CLA 2013-09-18 07:11:27 EDT 
(In reply to Daniel Rolka from comment #1)
> Gerrit review link: https://git.eclipse.org/r/#/c/16351/

The fix is quite big for 4.3.2. Is this really important enough for being backported?
Comment 3 Dani Megert CLA 2013-09-18 10:53:38 EDT 
See bug 417399 for a follow-up issue.
Comment 4 Paul Webster CLA 2013-09-20 10:13:17 EDT 
(In reply to Dani Megert from comment #2)
> 
> The fix is quite big for 4.3.2. Is this really important enough for being
> backported?

I was pushing for this because its a regression and there's no way to replicate this functionality for RCP applications that wish to force a starting perspective (I wanted an improved path for RCP apps to migrate to Kepler).

But if it's too risky I'm willing to defer it (which would just close this bug as it's already in Luna)

PW
Comment 5 Dani Megert CLA 2013-09-20 11:49:46 EDT 
(In reply to Paul Webster from comment #4)
> (In reply to Dani Megert from comment #2)
> > 
> > The fix is quite big for 4.3.2. Is this really important enough for being
> > backported?
> 
> I was pushing for this because its a regression and there's no way to
> replicate this functionality for RCP applications that wish to force a
> starting perspective (I wanted an improved path for RCP apps to migrate to
> Kepler).
> 
> But if it's too risky I'm willing to defer it (which would just close this
> bug as it's already in Luna)
> 
> PW

What worries me, is that the patch not just adds code to make the perspective appear if needed i.e. it contains code changes which are run even without -product being used. Plus, I think, an RCP writer can easily choose the initial perspective in the code. Personally, I would not backport this but I'd also not -1 it, if you think it's important and safe.
Comment 6 Paul Webster CLA 2013-11-04 15:16:28 EST 
OK, It's probably not worth the risk to patch this back to 4.3.2

Thank you for your effort, Daniel.

PW