Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 416952 - [server] Some GitTests fail when orion.file.layout=userTree
Summary: [server] Some GitTests fail when orion.file.layout=userTree
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Server (show other bugs)
Version: 4.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.0 M2   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 412995
  Show dependency tree
 
Reported: 2013-09-10 14:01 EDT by Anthony Hunter CLA
Modified: 2013-09-10 14:04 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Hunter CLA 2013-09-10 14:01:53 EDT
The default project layout on the Orion server is flat but you can optionally set the value orion.file.layout=userTree to turn on organizing the layout of the projects. The orion.eclipse.org server is using userTree.

When you add this setting to an orion.conf on a server against which the JUnit tests are run, many of the GitTests fail.

The problem is with the line:
		IFileStore fsStore = getProjectStore(wp, "test");
where "test" is being used as the userId to find the project root.

"test" is not actually the correct user id, so a user home is not found and the workspace root is used incorrectly within getProjectStore(). 

In the case of orion.file.layout=flat, the projects are actually under the workspace root so bug does not result in any test errors.

In the case of orion.file.layout=userTree, the projects are organized in a hierarchy so the incorrect project root results in test failures.
Comment 1 Anthony Hunter CLA 2013-09-10 14:04:47 EDT
Fixed with:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=f6ab4b91f315e3015d81f7c58c3417b6b3044f61

I also fixed the warnings in the file at the same time.