This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 416746 - [Trim] Toolbar not visible with 4.3 legacy mode
Summary: [Trim] Toolbar not visible with 4.3 legacy mode
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 M4   Edit
Assignee: Wojciech Sudol CLA
QA Contact: Wojciech Sudol CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-06 11:47 EDT by Marco Maccaferri CLA
Modified: 2018-07-09 04:52 EDT (History)
3 users (show)

See Also:

Attachments
Workbench file after first run (43.41 KB, text/plain)
2013-09-06 11:48 EDT, Marco Maccaferri CLA 		no flags Details
Sample RCP application (148.95 KB, application/zip)
2013-09-13 03:13 EDT, Marco Maccaferri CLA 		no flags Details
Screenshot of the application when it is run for the first time (17.16 KB, image/jpeg)
2013-09-13 08:03 EDT, Wojciech Sudol CLA 		no flags Details
Screenshot of the application when it is run for the second time (15.20 KB, image/jpeg)
2013-09-13 08:04 EDT, Wojciech Sudol CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Maccaferri CLA 2013-09-06 11:47:54 EDT 
I'm trying to port an RCP application from eclipse 3.8 to 4.3. Adding the necessary elements like LegacyIDE.e4xml and default css theme the application seems to work, however after the first restart the toolbar is not visible anymore. The toolbar is visible only when clearPersistedState is set to true, which is unacceptable because it resets all customized layouts.

After some more attempts I found that the toolbar is perfectly visible when running with eclipse 4.2, so it seems a regression of some kind with eclipse 4.3.
Comment 1 Marco Maccaferri CLA 2013-09-06 11:48:49 EDT 
Created attachment 235249 [details]
Workbench file after first run
Comment 2 Wojciech Sudol CLA 2013-09-10 10:29:32 EDT 
This problem occurs in 4.2.2 too (but not in 4.2.0).
Comment 3 Eric Moffatt CLA 2013-09-12 14:25:03 EDT 
Marco / Wojciech, any chance you could attach a small example RCP app that demonstrates this ?

Wojciech, thanks for testing where the issue seems to have crept in, how did you test it ?
Comment 4 Marco Maccaferri CLA 2013-09-13 03:13:37 EDT 
Created attachment 235455 [details]
Sample RCP application
Comment 5 Wojciech Sudol CLA 2013-09-13 08:03:02 EDT 
Created attachment 235461 [details]
Screenshot of the application when it is run for the first time
Comment 6 Wojciech Sudol CLA 2013-09-13 08:04:47 EDT 
Created attachment 235462 [details]
Screenshot of the application when it is run for the second time
Comment 7 Wojciech Sudol CLA 2013-09-13 08:05:45 EDT 
Eric,
I tested it using Marco's application. I attached screenshots that presents the bug. The toolbar with new, save and print buttons is not visibe when there is an entry for it in the workbench.xmi. If the entry is removed from the file, then it is visible again.
I am investigating it.
Comment 8 Eric Moffatt CLA 2013-12-05 14:17:15 EST 
Pushed

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=aad29ac0fb309642899d2e21a59ca0e43dc4197f

This works but we're still trying to determine if there's a fix we can provide at a slightly deeper level...I'll mark this as fixed since it does address the specific defect scenario.

We'll re-open if we want to change the solution...
Comment 9 Wojciech Sudol CLA 2013-12-10 08:16:10 EST 
Verified in I20131209-2000.