Community
Participate
Working Groups
As discussed on the e4 mailing list, it think the Eclipse platform should offer an dark theme. The purpose of this theme would be: 1.) Attract users which prefer a dark styled IDE (IntellJ, sublime users seem to prefer that) 2.) Show limitation in the current CSS styling (Button, table headers, etc.) and start working on them. My proposal would be to contribute this via a separate plug-in. If the platform team agrees to this approach, please let me know how the plug-in should be named (Bundle-Symbolic-Name). I will try to coordinate with the existing dark style plug-in providers and to contribute an initial styling.
Created attachment 235066 [details] image that demonstrates icon translucency problems I don't own the rights to this image, it's just for demonstrating Eclipse's issue with platform icons on dark backgrounds.
Aside from CSS changes, most of the current workbench icons look bad on a dark background. There are many gifs which don't support true translucency like PNG and other formats. I've attached a random example from Google image search that demonstrates this (check the edges of the run/play icon). We are working on replacement icons for similar reasons, which are available here: https://code.google.com/p/eclipse-svg-icons/
I asked Andrea Guarinoni who created https://github.com/guari/eclipse-ui-theme if this theme could be contributed to the Eclipse platform. Via email he confirmed that we can use his theme as basis. I ask him to confirm this in this bug report.
Hi, as said to Lars, you can use it as you like if it might be of some help.
Created attachment 237451 [details] DarkTheme Sample screenshot attached with the dark theme contributed by Andrea.
I plan to contribute the new theme in its own plug-in. Current name is "org.eclipse.ui.theme.dark". If no one disagrees with that in the next days, I talk that as agreement.
(In reply to Lars Vogel from comment #6) > I plan to contribute the new theme in its own plug-in. Current name is > "org.eclipse.ui.theme.dark". If no one disagrees with that in the next days, > I talk that as agreement. Why not put it in org.eclipse.platform like the other themes? Or arguably, do we need to move the other themes out into their own plugin (not in this bug, but another)? PW
Is there a way to automatically associate an .epf configuration for syntax highlighting with a stylesheet/plugin? So we can have it applied as default when the dark theme is selected.
(In reply to Andrea Guarinoni from comment #8) > Is there a way to automatically associate an .epf configuration for syntax > highlighting with a stylesheet/plugin? So we can have it applied as default > when the dark theme is selected. There isn't at the moment. But in Luna there is work to allow CSS to reference existing Color and Font definitions. It might make sense to provide a way to look a CSS theme with a more traditional Color and Font theme. PW
(In reply to Paul Webster from comment #7) > (In reply to Lars Vogel from comment #6) > > I plan to contribute the new theme in its own plug-in. Current name is > > "org.eclipse.ui.theme.dark". If no one disagrees with that in the next days, > > I talk that as agreement. > > Why not put it in org.eclipse.platform like the other themes? Or arguably, > do we need to move the other themes out into their own plugin (not in this > bug, but another)? I think themes relate to UI and should be part of the platform UI project. And I would like to make the themes consumable for RCP applications, this mean that a theme like dark theme should live in its own plug-in. See Bug 420836 for my suggestion to move the other CSS files also to their own plug-in in platform ui.
I converted and uploaded the initial contribution from Andrea. My preference would be to get this in as is (if the plug-in structure is not obviously wrong) and start improving it. I hope for example that based on the CSS work from Daniel Rolka we might be able to simplify the styling.
https://git.eclipse.org/r/#/c/21392/
Created attachment 239527 [details] Screenshot
First contributions merged with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=dd57ff612541e64ec8b14945c41cf259485c8a1c Looking at the existing plug-ins I suggest to name it either org.eclipse.e4.ui.themes or org.eclipse.ui.themes. https://git.eclipse.org/r/21521
Change the name to org.eclipse.e4.ui.themes with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e6c88938560769a2b7d607e9d4eb6917601b01f3 IIRC someone had concerns about org.eclipse.ui.themes, which I would prefer. I leave this bug open for a while to allow for feedback on the bundle symbolic name. Thanks Andrea for this great contribution!!!!
Paul Webster suggested via IRC to use "org.eclipse.ui.themes". Adjusted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=687d6d1b32cd040bf431d33bf8397c91655973f0
This change was not completely correct. The bundle now appears like this in the About dialog: providerName pluginName You could have easily seen/fix this by looking at the warnings. Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=071b6be09f82cfdc8d46d55bc1d003b983874f26
