This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 416170 - Please Create a spearate Branch to generify the JFace Viewers
Summary: Please Create a spearate Branch to generify the JFace Viewers
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M2   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-29 13:21 EDT by Hendrik Still CLA
Modified: 2013-09-17 13:57 EDT (History)
8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hendrik Still CLA 2013-08-29 13:21:27 EDT 
The current unfinished work at the JFace Viewers leads to a load of warnings in other projects like EMF. 
Is it possible to create a branch for the changes at the JFace Viewers and cherry-pick the following commits into this branch?

09f112418931b1826e7699594e0f2b9c86e265a4 TableViewer     Bug 413974
11849032c5d770fd1326a99aa96fcb25ea049810 CustomHashtable Bug 414067
5ccf110dcd23225e36764b336e3a6b1ab8987f08 JFace Snippets  Bug 414565
271b294d172cbd37cc253d4b2b1884b6e449ed38 ListViewer      Bug 414356
d5c62ff8e7265c5edbee67c8dbe2144cc113baa0 ComboViewer     Bug 412273


And also if the platform team agrees, then this commits should also be reverted in the master branch.

Best Regards,
Hendrik
Comment 1 John Arthorne CLA 2013-08-30 10:14:37 EDT 
What I have done so far:

- Created a tag of master before I touched anything:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tag/?id=v20130829-bug416170

- Created a new branch, to enable non-ff commits it needs to be a committer branch so it is currently called johna/402445

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/log/?h=johna/402445

Paul asked me to hold off on reverting anything until he gets back.
Comment 2 Hendrik Still CLA 2013-08-30 10:17:59 EDT 
Thank you John!

Is it still possible to use Gerrit to commit to this branch?
Comment 3 Lars Vogel CLA 2013-08-30 10:55:14 EDT 
Hendrik, push ref should be ref/for/john...instead of ref/for/master
Comment 4 John Arthorne CLA 2013-09-04 08:17:38 EDT 
I have reverted the five commits in master. I will get the jface branch rebased a bit later today.
Comment 5 John Arthorne CLA 2013-09-04 10:04:19 EDT 
I have re-applied the 5 commits in branch johna/402445, so I think you are good to continue working there.

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/log/?h=johna/402445
Comment 6 Paul Webster CLA 2013-09-17 13:57:17 EDT 
Yes, indeed.

PW