Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 416106 - I build failure - testPackageFragmentRootNonJavaResources3
Summary: I build failure - testPackageFragmentRootNonJavaResources3
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M2   Edit
Assignee: Jay Arthanareeswaran CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-29 02:48 EDT by Manoj N Palat CLA
Modified: 2013-09-02 00:33 EDT (History)
3 users (show)

See Also:


Attachments
Patch with pom changes (1.23 KB, patch)
2013-08-30 01:16 EDT, Jay Arthanareeswaran CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Manoj N Palat CLA 2013-08-29 02:50:21 EDT
unexpected non java resources. ----------- Expected ------------ META-INF\n MANIFEST.MF ------------ but was ------------ META-INF\n MANIFEST.MF\n ECLIPSE_.SF\n ECLIPSE_.RSA --------- Difference is ---------- expected:<...-INF\n MANIFEST.MF[]> but was:<...-INF\n MANIFEST.MF[\n ECLIPSE_.SF\n ECLIPSE_.RSA]> 

junit.framework.ComparisonFailure: unexpected non java resources.
----------- Expected ------------
META-INF\n
MANIFEST.MF
------------ but was ------------
META-INF\n
MANIFEST.MF\n
ECLIPSE_.SF\n
ECLIPSE_.RSA
--------- Difference is ----------
expected:<...-INF\n
MANIFEST.MF[]> but was:<...-INF\n
MANIFEST.MF[\n
ECLIPSE_.SF\n
ECLIPSE_.RSA]>
at org.eclipse.jdt.core.tests.junit.extension.TestCase.assertStringEquals(TestCase.java:238)
at org.eclipse.jdt.core.tests.junit.extension.TestCase.assertEquals(TestCase.java:214)
at org.eclipse.jdt.core.tests.model.AbstractJavaModelTests.assertResourceTreeEquals(AbstractJavaModelTests.java:588)
at org.eclipse.jdt.core.tests.model.JavaProjectTests.testPackageFragmentRootNonJavaResources3(JavaProjectTests.java:1498)
at org.eclipse.jdt.core.tests.model.SuiteOfTestCases$Suite.runTest(SuiteOfTestCases.java:104)
at org.eclipse.jdt.core.tests.model.SuiteOfTestCases$Suite.superRun(SuiteOfTestCases.java:88)
at org.eclipse.jdt.core.tests.model.SuiteOfTestCases$1.protect(SuiteOfTestCases.java:76)
at org.eclipse.jdt.core.tests.model.SuiteOfTestCases$Suite.run(SuiteOfTestCases.java:85)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:655)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:310)
at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:36)
at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:32)
at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:109)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:80)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:372)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:226)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
at org.eclipse.core.launcher.Main.main(Main.java:34)
Comment 2 Jay Arthanareeswaran CLA 2013-08-29 02:51:52 EDT
This occurs only in the nightly build and looks related to the signing of the JAR files. I will take a look at this.
Comment 3 Dani Megert CLA 2013-08-29 07:00:56 EDT
(In reply to comment #2)
> This occurs only in the nightly build and looks related to the signing of
> the JAR files. I will take a look at this.

It's the other way around, since N-builds aren't signed.
Comment 4 Jay Arthanareeswaran CLA 2013-08-29 07:22:12 EDT
(In reply to comment #3)
> (In reply to comment #2)
> > This occurs only in the nightly build and looks related to the signing of
> > the JAR files. I will take a look at this.
> 
> It's the other way around, since N-builds aren't signed.

Yes, that's what I meant. Anyway, looks like we already made a fix to the eclipse.inf in the corresponding project via bug 401141. But I don't know why it came back.

Thanh, I see this in the eclipse.inf:

jarprocessor.exclude.pack=true
jarprocessor.exclude.children=true

This should have been enough, right?
Comment 5 Thanh Ha CLA 2013-08-29 09:39:27 EDT
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > This occurs only in the nightly build and looks related to the signing of
> > > the JAR files. I will take a look at this.
> > 
> > It's the other way around, since N-builds aren't signed.
> 
> Yes, that's what I meant. Anyway, looks like we already made a fix to the
> eclipse.inf in the corresponding project via bug 401141. But I don't know
> why it came back.
> 
> Thanh, I see this in the eclipse.inf:
> 
> jarprocessor.exclude.pack=true
> jarprocessor.exclude.children=true
> 
> This should have been enough, right?

Jay, see David's comment in Bug 401098 comment 13.

Basically as we found out Bug 412850 Tycho does not support the eclipse.inf file settings and according to Tycho developers it would be difficult for them to support this so we decided to implement this in a different way inside the jarsigner plugin.


You will need to add additional pom.xml changes which David explains your options in Bug 401098 comment 13. Let me know if anything can be clarified.
Comment 6 Jay Arthanareeswaran CLA 2013-08-30 01:16:16 EDT
Created attachment 235002 [details]
Patch with pom changes

There were two bundles that required this:

org.eclipse.jdt.core.tests.compiler
org.eclipse.jdt.core.tests.model
org.eclipse.jdt.core

I know it shouldn't matter, but just to make sure that nightly builds won't be broken, I will build it locally before pushing it.
Comment 7 Jay Arthanareeswaran CLA 2013-08-30 03:30:58 EDT
The local build went alright and released the pom changes here:

http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=3d56013cb187944d7b87c9178836e465733a4159

Will have to wait for the next I build to see the results, though.
Comment 8 Jay Arthanareeswaran CLA 2013-09-02 00:33:12 EDT
Test have been passing in the last two I builds and I have also verified that ecj.jar is not signed in build I20130830-2000.