This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 416082 - PartServiceImpl should use EModelService for model object creation instead of BasicFactoryImpl
Summary: PartServiceImpl should use EModelService for model object creation instead of...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 M2   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 402781
Blocks:
  Show dependency tree
 
Reported: 2013-08-28 14:07 EDT by Lars Vogel CLA
Modified: 2013-09-17 05:33 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2013-08-28 14:07:17 EDT 

    


    


      



        
          Comment 1
        

        
          Lars Vogel CLA

        

        
        

        
          2013-08-28 14:10:13 EDT
        

      






Suggested Fix in Gerrit

    


    


      



        
          Comment 2
        

        
          Lars Vogel CLA

        

        
        

        
          2013-08-28 14:11:32 EDT
        

      






https://git.eclipse.org/r/#/c/15945/

    


    


      



        
          Comment 3
        

        
          Eric Moffatt CLA

        

        
        

        
          2013-08-29 14:47:31 EDT
        

      






Thanks Lars, we'll look at this for the next milestone. Now all we have to do is to switch over to using the @UIEventTopics...;-).

    


    


      



        
          Comment 4
        

        
          Eric Moffatt CLA

        

        
        

        
          2013-09-04 10:05:07 EDT
        

      






Committed:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9db76a062b421f3bc3540e3a9f0bc113e194f861

Thanks Lars... I guess I should make similar changes in the ModelServiceImpl..;-).

    


    


      



        
          Comment 5
        

        
          Lars Vogel CLA

        

        
        

        
          2013-09-04 10:20:01 EDT
        

      






> Thanks Lars... I guess I should make similar changes in the
> ModelServiceImpl..;-).

I'm happy to provide a patch. Should be done by tomorrow.

    


    


      



        
          Comment 6
        

        
          Lars Vogel CLA

        

        
        

        
          2013-09-04 14:48:01 EDT
        

      






Looks like Jonas takes Bug 402781 and will provide a patch to use EcoreUtil.create. So I leave that to him.

    


    

    


      



        
          Comment 8
        

        
          Daniel Rolka CLA

        

        
        

        
          2013-09-17 05:33:30 EDT
        

      






Verified in the build: I20130916-2330