This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 415898 - [regression] Active editor changed when switching perspective
Summary: [regression] Active editor changed when switching perspective
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.3.1   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 388617
Blocks:
  Show dependency tree
 
Reported: 2013-08-26 14:10 EDT by Eric Moffatt CLA
Modified: 2013-08-30 09:29 EDT (History)
14 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2013-08-26 14:10:19 EDT
+++ This bug was initially created as a clone of Bug #388617 +++

When switching from Debug perspective to Java, the file that last had focus/was active in the Java perspective is again active.

I expect the active editor to be the one that was active in the debug perspective.

This is very irritating as I have to take an extra action to get to where I was in the Debug perspective.

When I shift back to the Debug perspective, in the other direction (from Java to Debug), the debug perspective shows the tab that was active in the Java perspective. I now have to go the Debug view, find the thread again, and double click to get the editor tab for "where I was".

(Perspective shift is done with the buttons in the upper right.)

This is a major usability issue as it disrupts the flow of thought.
Comment 1 Eric Moffatt CLA 2013-08-26 14:22:13 EDT
4.3.1 version of the defect...here's the Gerrit link:

https://git.eclipse.org/r/15860

Note that while testing this I noticed that the stacks weren't being styled correctly but all the activations work as they do in 4.4. This is almost certainly the result of not back-porting Bug 408849 which contains a change in how we style the stacks...
Comment 2 Dani Megert CLA 2013-08-29 08:29:03 EDT
(In reply to comment #1)
> 4.3.1 version of the defect...here's the Gerrit link:
> 
> https://git.eclipse.org/r/15860
> 

It looks like despite filing that Gerrit change, you directly cherry-picked the broken fix (see bug 388617 comment 14) into 'R4_3_maintenance'. This causes 32 test failures in our 4.3 SR1 RC2 test candidate build.

We need to revert that change, optionally review and backport the second fix (see bug 388617 comment 16) and then do a rebuild.
Comment 3 Eric Moffatt CLA 2013-08-29 10:59:11 EDT
Committed:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_3_maintenance&id=9c49aaa641e1c0aec33d447c8cb1db14a8fcaa4c

This reverts the breaking changes and adds the more surgical fix now in 4.4.
Comment 4 Eric Moffatt CLA 2013-08-29 13:39:45 EDT
I'll wait for the new M-build before verifying this one...
Comment 5 Dani Megert CLA 2013-08-30 09:28:46 EDT
(In reply to comment #4)
> I'll wait for the new M-build before verifying this one...

The test results are green. I also verified that it fixes the bug using the steps from bug 388617 comment 6. However, while doing so, I found an even worse issue: when switching back to the 'Java' perspective, it gets "polluted" with the 'Project Explorer'! But since that's also happening in 4.3 we can close this one. I filed bug 416235 to track the new issue.
Comment 6 Dani Megert CLA 2013-08-30 09:28:54 EDT
.