This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 415522 - [IDE] Clean dialog should scroll to reveal selected projects
Summary: [IDE] Clean dialog should scroll to reveal selected projects
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M4   Edit
Assignee: Christian Georgi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 424173
Blocks:
  Show dependency tree
 
Reported: 2013-08-20 15:46 EDT by Curtis Windatt CLA
Modified: 2014-05-31 04:06 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2013-08-20 15:46:46 EDT 
1) Select one or more projects in the workspace
2) Project > Clean...
3) Clean selected projects
Result:
If you have a lot of projects, the checked projects are buried.

We should reveal the first checked project.
Comment 1 Curtis Windatt CLA 2013-08-20 16:02:00 EDT 
https://git.eclipse.org/r/#/c/15667/
Possible fix.

Mike, can you give this a quick sanity check?
Comment 2 Dani Megert CLA 2013-08-21 05:50:10 EDT 
(In reply to comment #1)
> https://git.eclipse.org/r/#/c/15667/
> Possible fix.
> 
> Mike, can you give this a quick sanity check?

When using Gerrit, it's better to add the person as reviewer directly there.
Comment 3 Curtis Windatt CLA 2013-10-03 16:47:10 EDT 
I have no time for this, closing.
Comment 4 Christian Georgi CLA 2013-11-03 13:35:02 EST 
Dani, can you review this again?  I have updated https://git.eclipse.org/r/#/c/15667/.
Comment 5 Curtis Windatt CLA 2013-11-04 10:24:07 EST 
Reopening as Christian has added a new patch.
Comment 6 Dani Megert CLA 2013-11-06 04:57:36 EST 
(In reply to Christian Georgi from comment #4)
> Dani, can you review this again?  I have updated
> https://git.eclipse.org/r/#/c/15667/.

Thanks Christian.

Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d7c42382aafc4b9ac02b7994f8add1131dac19f2

Updated copyright notice with: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=fa5555b206b236a520533375f65f0c1558081ef1
Comment 7 Paul Webster CLA 2013-12-12 06:02:11 EST 
I select a project at the bottom of the package explorer and use Project>Clean...  The dialog opens (and I have clean Clean projects selected below chosen) and it doesn't scroll to the only checked project.

4.4.0.I20131209-2000 Linux

PW
Comment 8 Christian Georgi CLA 2013-12-12 06:48:29 EST 
I could reproduce this on Linux GTK.  Table.showItem() doe not seem to work unless called in an asyncExec block.

Fix: https://git.eclipse.org/r/19692
Comment 9 Dani Megert CLA 2013-12-16 09:17:50 EST 
(In reply to Christian Georgi from comment #8)
> I could reproduce this on Linux GTK.  Table.showItem() doe not seem to work
> unless called in an asyncExec block.
> 
> Fix: https://git.eclipse.org/r/19692

This rather sounds like an SWT bug or a bug in how the dialog is created. Adding an asyncExec should be avoided.
Comment 10 Christian Georgi CLA 2013-12-16 09:21:45 EST 
Ok, then how to get SWT people in the loop?
Comment 11 Dani Megert CLA 2013-12-16 10:26:38 EST 
(In reply to Christian Georgi from comment #10)
> Ok, then how to get SWT people in the loop?

Well, first you need to figure out whether it is an SWT issue. Try to reproduce the bug in an existing SWT snippet or provide an isolated test case and then move the bug to SWT.
Comment 12 Paul Webster CLA 2013-12-16 15:01:27 EST 
I opened Bug 424173 for SWT, I can reproduce it with a table snippet.

PW
Comment 13 Dani Megert CLA 2013-12-17 03:20:32 EST 
(In reply to Paul Webster from comment #12)
> I opened Bug 424173 for SWT, I can reproduce it with a table snippet.
> 
> PW

Thanks Paul!

Marking this one as fixed, since the fix itself seems OK.
Comment 14 Eric Moffatt CLA 2014-05-30 13:49:41 EDT 
It may be fixed but I can't VERIFY it since the SWT side isn't done...
Comment 15 Dani Megert CLA 2014-05-31 04:06:20 EDT 
(In reply to Eric Moffatt from comment #14)
> It may be fixed but I can't VERIFY it since the SWT side isn't done...

It can be verified on any platform but Linux, where the SWT bug kicks in.

Verified in I20140530-2000.