This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 415343 - Suspicious dead code in BindingPersistence
Summary: Suspicious dead code in BindingPersistence
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M2   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 415342
  Show dependency tree
 
Reported: 2013-08-19 09:53 EDT by Dani Megert CLA
Modified: 2013-09-17 13:53 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2013-08-19 09:53:10 EDT 
1. WARNING in /Eclipse UI/org/eclipse/ui/internal/keys/BindingPersistence.java
 (at line 569):

} else if (viewParameter != null) { HashMap parms = new HashMap(); parms.put(ShowViewMenu.VIEW_ID_PARM, viewParameter); parameterizedCommand = ParameterizedCommand.generateCommand(command, parms); } else {

Dead code


Not sure whether we could just remove the dead code along with 'viewParameter' or whether 'viewParameter' should get properly initialized.
Comment 1 Dani Megert CLA 2013-08-19 09:53:42 EDT 
Paul, can you take a look?
Comment 2 Paul Webster CLA 2013-08-20 09:04:22 EDT 
That definitely looks like dead code, from the time where we offered free open keybindings for views.  I will remove it.

PW
Comment 3 Dani Megert CLA 2013-08-22 04:00:07 EDT 
(In reply to comment #2)
> That definitely looks like dead code, from the time where we offered free
> open keybindings for views.  I will remove it.
> 
> PW

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=84a3c101312c88f7c0bc50a8404e6b98b5381898
Comment 4 Paul Webster CLA 2013-09-17 13:53:20 EDT 
In 4.4.0.I20130916-2330

PW