Community
Participate
Working Groups
I attempted to word the summary in a generic fashion, even though it's somewhat hard to understand that way. I don't know whether this should be considered a documentation bug, or an "inline help" bug, or a functionality bug. It's simplest to describe this with an example. It's very non-obvious to see how to get the dialog to list ONLY all "*.js" files, and not also "*.jsp" or "*.jspx" files. The solution, which was pointed out to me at <http://www.eclipse.org/forums/index.php/m/1086703/#msg_1086703> is completely nonintuitive. It's somewhat intuitive to suggest that if you enter "*.js", then perhaps changing it to "*.js " (appending a space) would work. That doesn't work. What does work is "*js " (removing the period, but adding the space) or the even more bizarre "*js<". I never would have thought to remove the period, and certainly not adding "<". Although these workarounds are non-intuitive, they would be reasonable if the hints in the dialog made it clear that you have to do this. The "?" help on this dialog is useless. There's a simple hint on the field in the dialog that just says this: ? = any character, * = any string Perhaps it would be possible to extend this inline help with some statement that made it clear how this works, but I'm having trouble visualizing what that statement would look like.
In this case the '<' is the correct thing to add to mark that the match should be at the end of the line. The Open Type Dialog works the same way. It should be added to the dialog help or to the hint string. PW
(In reply to comment #1) > In this case the '<' is the correct thing to add to mark that the match > should be at the end of the line. The Open Type Dialog works the same way. > > It should be added to the dialog help or to the hint string. > > PW It is in the F1 help, but unfortunately it doesn't work for file extensions.
Would you mind clarifying that statement? I don't understand what that means.
(In reply to comment #3) > Would you mind clarifying that statement? I don't understand what that > means. "<" and " " are described in the F1 help, but it does not work if the pattern also includes file extensions, like e.g. "*.js". It's a bug in our code.
I see. After viewing the initial F1 info, and you think to click the "Open Resource Dialog" in the "See Also" link, it does have the following statement in the "Wildcards" section: 'terminating "<" or " " (space) to prevent the automatic prefix matching, e.g. "M*file<" to match Makefile and MockFile but not MakeTheFiles' So it might be good to make this functionality a little more visible, but there is also a bug that prevents this from working with the "*.js<" pattern, although it does with the less intuitive "*js<" pattern. Was a bug ever filed for that?
(In reply to comment #5) > So it might be good to make this functionality a little more visible, but > there is also a bug that prevents this from working with the "*.js<" > pattern, although it does with the less intuitive "*js<" pattern. Was a bug > ever filed for that? This bug report covers that.
CQ:WIND00433784
I pushed a patch to gerrit for review: https://git.eclipse.org/r/23807 This fixes also camel case patterns with a folder prefix, like eg. */FR I noticed that the basename part is matched as prefix, ie. th.txt would match both this.txt and that.txt. While th.txt< would neither match this.txt nor that.txt. I was not sure if this is expected/desired and left it unchanged.
Thanks Anton! Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2ff406374e7eb37894efe389c33e2ae7e241147b
In 4.4.0.I20140501-0200 PW
