Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 415000 - [server] tests need to update the user in the MetaStore
Summary: [server] tests need to update the user in the MetaStore
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Server (show other bugs)
Version: 4.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.0 M1   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 412995
  Show dependency tree
 
Reported: 2013-08-13 13:11 EDT by Anthony Hunter CLA
Modified: 2013-08-13 14:00 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Hunter CLA 2013-08-13 13:11:52 EDT 
In an identical issue to Bug 413655 ( AuthorizationService.addUserRight() adds roles before the admin user is created ), the server tests need a similar tweak to how it interacts with users in the MetaStore

The AbstractServerTest adds a user in createUser() but does not add the user to the MetaStore via an addUser(). This change is required just like the change we made in Bug 413655.

In addition, the Git tests make the call:
AuthorizationService.removeUserRight("test", "/");

when it should not be assuming the userId and loginId match, the implementation should be
AuthorizationService.removeUserRight(testUserId, "/"); 

to match the addUserRight() implementation in the AbstractServerTest
Comment 1 Anthony Hunter CLA 2013-08-13 14:00:23 EDT 
Fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=5aa62b7c35470ee750285d21695dea24cf6d89dc 

The git tests run successfully with this change.