This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 414995 - Minimizing Editor Stack does not minimise to tool bar
Summary: Minimizing Editor Stack does not minimise to tool bar
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 4.3.1   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 408920
Blocks:
  Show dependency tree
 
Reported: 2013-08-13 11:39 EDT by Curtis Windatt CLA
Modified: 2013-08-14 10:45 EDT (History)
4 users (show)

See Also:
curtis.windatt.public: review+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2013-08-13 11:39:27 EDT
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=74f064e095b6118334f3be864b4827d4bc97ed6a

Cloned to backport this fix to 4.3.1 

+++ This bug was initially created as a clone of Bug #408920 +++

Since perhaps M7, minimizing an editor stack just shrinks the editor area to a perhaps 640/480 overlay.

The problem is related to my last commment.  We are not validating the part to activate if we are looking at siblings.  Since views in the same stack are not considered siblings, the code would always use findActivationCandidate(), which checks if each candidate is valid.  The editors are siblings (belonging to an MArea), so they are checked if they are to be rendered, but not if they are valid.

The fix is very simple and fixes more scenarios than comment #11 steps.  for example, when two editors are in a fast view, pressing the escape key will switch editors, rather than close the fast view.
Comment 1 Eric Moffatt CLA 2013-08-13 14:13:37 EDT
+1, looks (and works) great !
Comment 3 Dani Megert CLA 2013-08-14 10:45:40 EDT
Verified in M20130814-0800.