Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 414560 - [core.etphys][core.room] rename some attributes and references, use unordered groups
Summary: [core.etphys][core.room] rename some attributes and references, use unordered...
Status: RESOLVED FIXED
Alias: None
Product: eTrice
Classification: Modeling
Component: Core (show other bugs)
Version: 0.3.0   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 0.4.0M1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: consolidation
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-07 06:15 EDT by Henrik Rentz-Reichert CLA
Modified: 2013-08-07 12:21 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henrik Rentz-Reichert CLA 2013-08-07 06:15:16 EDT 
Proposed renamings:

Attribute.refType -> type
StandardOperation.returntype -> returnType
PortOperation.returntype -> returnType
ActorClass.ifPorts -> interfacePorts
ActorClass.ifSPPs -> serviceProvisionPoints
ActorClass.intPorts -> internalPorts
ActorClass.extPorts -> externalPorts
ActorClass.strSAPs -> serviceAccessPoints
ProtocolClass.conjugate -> conjugated (keyword conjugate or conjugated)
ExternalPort.ifport -> interfacePort
SAPRef -> SAP
SPPRef -> SPP
SubSystemClass.ifSPPs -> serviceProvisionPoints
ActorRef.size -> multiplicity
DetailCode.commands -> lines
Documentation.text -> lines

Use of unordered groups (& separated) in
SubSystemClass
		relayPorts+=Port*
		ifSPPs+=SPPRef*
		actorRefs+=ActorRef*
		bindings+=Binding*
		connections+=LayerConnection*
		threads+=LogicalThread*
		actorInstanceMappings+=ActorInstanceMapping*

LogicalSystem
		subSystems+=SubSystemRef*
		bindings+=Binding*
		connections+=LayerConnection*

ActorClass
		(intPorts+=Port |
		extPorts+=ExternalPort)*
		serviceImplementations+=ServiceImplementation*
		strSAPs+=SAPRef*
		attributes+=Attribute*
		actorRefs+=ActorRef*
		bindings+=Binding*
		connections+=LayerConnection*

Replace + with * multiplicity and do validation (eventually including quick fix)
CompoundProtocolClass.subProtocols
PortClass
		(attributes+=Attribute |
		operations+=PortOperation |
		msgHandlers+=MessageHandler)+
DetailCode.commands
Documentation.text
Comment 1 Henrik Rentz-Reichert CLA 2013-08-07 06:33:10 EDT 
Proposed changes in etphys:

Use unordered groups in
NodeClass
		'runtime' '=' runtime=[RuntimeClass|FQN]
		'priomin' '=' priomin=PRIO
		'priomax' '=' priomax=PRIO

PhysicalThread
		'execmode' '=' execmode=ExecMode
		('interval' '=' time=TIME)?
		'prio' '=' prio=PRIO
		'stacksize' '=' stacksize=INT
		'msgblocksize' '=' msgblocksize=INT
		'msgpoolsize' '=' msgpoolsize=INT
Comment 2 Henrik Rentz-Reichert CLA 2013-08-07 12:21:16 EDT 
Done with
3b077b417cfe120a1d6ac0133c9981f5c36d1208