Community
Participate
Working Groups
I just deleted my offline cache (due to bug 413363) and manually marked all review tasks for synchronization. I was getting a handfull of NPEs in the error log: Caused by: java.lang.NullPointerException at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:374) at org.eclipse.mylyn.reviews.internal.core.model.Review.setKey(Review.java:486) at org.eclipse.mylyn.internal.gerrit.core.remote.GerritReviewRemoteFactory.createModel(GerritReviewRemoteFactory.java:163) at org.eclipse.mylyn.internal.gerrit.core.remote.GerritReviewRemoteFactory.createModel(GerritReviewRemoteFactory.java:1) at org.eclipse.mylyn.reviews.core.spi.remote.emf.RemoteEmfConsumer.applyModel(RemoteEmfConsumer.java:219) at org.eclipse.mylyn.reviews.core.spi.remote.JobRemoteService$3.run(JobRemoteService.java:95) at org.eclipse.ui.internal.UILockListener.doPendingWork(UILockListener.java:164) at org.eclipse.ui.internal.UISynchronizer$3.run(UISynchronizer.java:158) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135) ... 23 more This happened both with "Synchronization failed" and being throw directly (Unhandled event loop exception).
Could be releated to bug 414461. But since there was no indication which task failed, I can't be sure if the review I opened and where I observerd the behavious described in 414461 was also one that triggered this NPE here.
(In reply to comment #1) > Could be releated to bug 414461. But since there was no indication which task > failed, I can't be sure if the review I opened and where I observerd the > behavious described in 414461 was also one that triggered this NPE here. My guess is yes. But let's leave it open for now. Thanks for the bug (and your patience!), Thomas.
(In reply to comment #2) > (In reply to comment #1) > > Could be releated to bug 414461. But since there was no indication which task > > failed, I can't be sure if the review I opened and where I observerd the > > behavious described in 414461 was also one that triggered this NPE here. > > My guess is yes. But let's leave it open for now. Thanks for the bug (and your > patience!), Thomas. Sorry, thought you were referring to a different bug. No, it looks like another vairant of bug 413480. Any time we see "org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:374) the root cause is that the notifier internal state isn't consistent. *** This bug has been marked as a duplicate of bug 413480 ***
