This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 414142 - Setting clientArea disabled in WorkbenchWindow#run(..) still allows typing in Editor
Summary: Setting clientArea disabled in WorkbenchWindow#run(..) still allows typing in...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.3.1   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 409423
Blocks:
  Show dependency tree
 
Reported: 2013-07-31 10:24 EDT by Eric Moffatt CLA
Modified: 2013-08-12 10:08 EDT (History)
6 users (show)

See Also:
pwebster: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2013-07-31 10:24:24 EDT 
+++ This bug was initially created as a clone of Bug #409423 +++

From Bug 409274

As part of fixing bug 404016, we disable disableControl(tpl.clientArea, toEnable); and that should disable all typing in the views and editors.

Despite the ancestor of the editor StyledText being disabled, we were still able to type into the editor.

PW
Comment 1 Eric Moffatt CLA 2013-07-31 10:25:15 EDT 
Paul, this should be simple enough to cherry pick directly I think...
Comment 3 Paul Webster CLA 2013-08-01 10:02:40 EDT 
.
Comment 4 Dani Megert CLA 2013-08-12 09:46:19 EDT 
(In reply to comment #2)
> Released as
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?h=R4_3_maintenance&id=6d8dea6d845c627a4aa0a6386a9bf632ce26d798
> 
> PW

This fix forgot to update the bundle version for 'org.eclipse.e4.ui.workbench.renderers.swt'.

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=183e2ed63be0a3a5a7e50af3b16185ec66275708
Comment 5 Dani Megert CLA 2013-08-12 10:08:12 EDT 
Verified in M20130807-1400. Also verified that regression bug 409274 is not present.