This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 414050 - [FastView] Fast views do not always close on Escape
Summary: [FastView] Fast views do not always close on Escape
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3.1   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 371598
Blocks:
  Show dependency tree
 
Reported: 2013-07-30 13:51 EDT by Eric Moffatt CLA
Modified: 2013-08-29 04:59 EDT (History)
8 users (show)

See Also:
pwebster: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2013-07-30 13:51:54 EDT 
+++ This bug was initially created as a clone of Bug #371598 +++

Environment: Linux 64bit, GTK, Eclipse for RCP and RAP developers package 4.2M5

Steps to reproduce:
* Focus a code editor
* Invoke unit tests using Ctrl+X, T
-> Junit view opens as fast view (note that the fast view icon does not change to pressed state)
* Press ESC to close the fast view again
-> Fast view does not close
* Click into the code editor
-> Not even this closes the fast view

Other views show a similar behavior. For example, the Call Hierarchy fast view does also not close on ESC, but it does on focus out. In contrast to the JUnit view, its icon changes state when the view opens.

The Console fast view seems to always close on ESC and focus lost, as expected.
Comment 1 Eric Moffatt CLA 2013-07-30 13:54:18 EDT 
Paul, this one should certainly be backported, it's a *major* pain point when debugging with a max'd editor area...

I'm not sure whether or not this patch will apply in the 4.3.1 branch because it reverts a previous commit that isn't on the maintenance branch.
Comment 2 Paul Webster CLA 2013-07-30 14:58:01 EDT 
I can't cherry-pick this one.  Could you please push this to Gerrit and I'll review it there.

PW
Comment 3 Eric Moffatt CLA 2013-07-30 15:07:42 EDT 
Done...

New Changes:
  https://git.eclipse.org/r/14988

Seems like EGit is smart enough to do gerrit pushes to the current branch, at least I didn't have to change anything while doing 'Push to Gerrit'...
Comment 5 Daniel Rolka CLA 2013-08-29 04:59:07 EDT 
Verified in the build: M20130828-0800