Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 413936 - Busy (italic) view title not redrawn promptly with Classic theme
Summary: Busy (italic) view title not redrawn promptly with Classic theme
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M4   Edit
Assignee: Daniel Rolka CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 413509 (view as bug list)
Depends on:
Blocks: 440086
  Show dependency tree
 
Reported: 2013-07-29 13:38 EDT by Markus Keller CLA
Modified: 2016-07-08 11:02 EDT (History)
5 users (show)

See Also:

Attachments
The patch proposal (843 bytes, text/plain)
2013-10-29 04:41 EDT, Daniel Rolka CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2013-07-29 13:38:20 EDT 
4.3.0.I20130605-2000

With the "Windows 7 Classic" theme, view titles are not immediately redrawn when the view changes its busy state. I could not reproduce with an E4 theme.

Steps:
- enable "Always run in background"
- select "Windows 7 Classic" theme
- restart
- Open Type Hierarchy (Ctrl+Shift+H)
- enter an often-used type, e.g. Serializable or Comparable (in reasonably small workspaces, you can also use Object)

=> View title only goes italic when I move the mouse over the view tab folder. It also stays italic until long after the progress view shows that the job is done. Again, moving the mouse over the tab bar corrects the rendering.
Comment 1 Paul Webster CLA 2013-07-29 14:00:07 EDT 
*** Bug 413509 has been marked as a duplicate of this bug. ***
Comment 2 Daniel Rolka CLA 2013-10-29 04:41:49 EDT 
Created attachment 236996 [details]
The patch proposal

The issue is connected to setting the 'swt-tab-renderer' CSS property to null for the 'MPartStack' class in the classic stylesheets. It disables the refresh. By adding the 'color' property to the class the refresh is enabled again.

Since I have some issue with committing the patch to Gerrit I've created the plain patch for it.

Paul,

Could you please review it?

thanks,
Daniel
Comment 3 Paul Webster CLA 2013-10-29 09:01:47 EDT 
(In reply to Daniel Rolka from comment #2)
> Created attachment 236996 [details]
> The patch proposal

Hi Daniel,

You should push that to Gerrit, we can review that next week.

PW
Comment 4 Daniel Rolka CLA 2013-10-30 15:32:52 EDT 
Gerrit review link: https://git.eclipse.org/r/#/c/17903/

Daniel
Comment 6 Daniel Rolka CLA 2013-12-10 13:06:07 EST 
Verified in the build: I20131209-2000

Daniel
Comment 7 Markus Keller CLA 2014-10-13 07:49:06 EDT 
Note that this problem hasn't been fixed in any official release, see bug 440086.