Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 413561 - [regression] NPE in ReviewDetailSection.createReviewersSubSection
Summary: [regression] NPE in ReviewDetailSection.createReviewersSubSection
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 415490
  Show dependency tree
 
Reported: 2013-07-23 14:30 EDT by Sam Davis CLA
Modified: 2013-12-19 13:18 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2013-07-23 14:30:42 EDT
I got this when refreshing a review.

!ENTRY org.eclipse.mylyn.tasks.ui 4 2 2013-07-23 11:26:01.556
!MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.mylyn.tasks.ui".
!STACK 0
java.lang.NullPointerException
	at org.eclipse.mylyn.reviews.ui.spi.editor.ReviewDetailSection.createReviewersSubSection(ReviewDetailSection.java:84)
	at org.eclipse.mylyn.reviews.ui.spi.editor.ReviewDetailSection.createContent(ReviewDetailSection.java:64)
	at org.eclipse.mylyn.internal.tasks.ui.editors.AbstractTaskEditorSection.createSectionClient(AbstractTaskEditorSection.java:129)
	at org.eclipse.mylyn.internal.tasks.ui.editors.AbstractTaskEditorSection.createControl(AbstractTaskEditorSection.java:59)
	at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.initializePart(AbstractTaskEditorPage.java:1309)
	at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.access$7(AbstractTaskEditorPage.java:1301)
	at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage$14.run(AbstractTaskEditorPage.java:857)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.createParts(AbstractTaskEditorPage.java:848)
	at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.createParts(AbstractTaskEditorPage.java:833)
	at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.createFormContentInternal(AbstractTaskEditorPage.java:720)
	at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.refresh(AbstractTaskEditorPage.java:1437)
	at org.eclipse.mylyn.reviews.ui.spi.editor.AbstractReviewTaskEditorPage.refresh(AbstractReviewTaskEditorPage.java:110)
	at org.eclipse.mylyn.tasks.ui.editors.TaskEditor.refreshPages(TaskEditor.java:702)
	at org.eclipse.mylyn.internal.tasks.ui.actions.SynchronizeEditorAction$1$1.run(SynchronizeEditorAction.java:72)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4144)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3761)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2701)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2665)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2499)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:679)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:668)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:353)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:180)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:601)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:629)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:584)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1438)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1414)
Comment 1 Miles Parker CLA 2013-07-29 18:29:11 EDT
Somehow we've lost the repository record. This might be a clue to the persistence issues. I'm wondering if the changes to the authorization/configuration code have created an issue with IRepostiory not getting set somehow.
Comment 2 Steffen Pingel CLA 2013-07-30 04:45:03 EDT
It looks like the model was corrupted which resulted in a number of exceptions after that.
Comment 3 Miles Parker CLA 2013-07-31 15:33:30 EDT
Agreed. I wonder if this could have been caused by Bug 413957. Sam, could you verify if this still fails with that?
Comment 4 Sam Davis CLA 2013-07-31 19:13:57 EDT
No. I don't know how to reproduce this.
Comment 5 Tomasz Zarna CLA 2013-08-19 05:49:08 EDT
I was just hit by this when desperately trying to reproduce bug 414461 by opening and immediately closing a bunch of reviews ( while on https://git.eclipse.org/r/#/c/15004/7 )*

* my guess it that this may be optional
Comment 6 Steffen Pingel CLA 2013-08-19 13:44:28 EDT
Is this essentially the same problem that is being discussed on bug 414799? Just wondering if we could simplify the discussion by marking this as a duplicate.
Comment 7 Tomasz Zarna CLA 2013-08-20 10:23:37 EDT
I would say "yes" to that. I saw it at least once when working on bug 414799, so they are at least related.
Comment 8 Miles Parker CLA 2013-08-21 15:15:28 EDT
Yes from me as well. This isn't acutally a dup then, given my bug 410580 comment 1. Here, note that ReviewDetailSection / AbstractReviewSection don't actually have their own observers, since they don't need to be notified explicitly. Instead, the life-cycle is implicitly managed by the AbstractReviewTaskEditorPage. My assumption was that the section's life-cycle was fully managed by the containing task editor page and that disposal of them would be predictable and conssitent. But perhaps this isn't the case..?
Comment 9 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn