This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 413516 - [DND] Editor closed and content lost when dropping detached editor's tab outside its window
Summary: [DND] Editor closed and content lost when dropping detached editor's tab outs...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: 4.3.1   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 410828
Blocks:
  Show dependency tree
 
Reported: 2013-07-23 08:39 EDT by Paul Webster CLA
Modified: 2013-08-28 14:17 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2013-07-23 08:39:07 EDT 
Backport to 4.3.1

+++ This bug was initially created as a clone of Bug #410828 +++

4.3 RC4

Make an editor dirty (change some content) and then drag it outside the workbench window to create a detached editor shell. Create a new workbench window, and then drag the detached editor's tab into the new workbench window.

Expected: Either drop cursor becomes "cannot drop" and dropping does nothing, or drop works and the dirty editor ends up in the new window.

Was: Editor is closed without any questions, and my content changes are lost.
Comment 1 Eric Moffatt CLA 2013-07-24 13:08:20 EDT 
Here's the 4.3.1 Gerrit:

  https://git.eclipse.org/r/14833
Comment 3 Dani Megert CLA 2013-07-30 09:25:04 EDT 
The bundle version of 'org.eclipse.e4.ui.workbench.addons.swt' needs to be adjusted.

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=59d2e9cb28f973f8167e535ee29c70b258ec6e83
Comment 4 Paul Elder CLA 2013-08-28 14:17:19 EDT 
Verified in build 4.3.0.M20130828-0800 on Win 7-64