413499 – Fix compiler warnings in org.eclipse.jface.commands caused by moving JFace to Java 1.5

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 413499 - Fix compiler warnings in org.eclipse.jface.commands caused by moving JFace to Java 1.5

Summary: Fix compiler warnings in org.eclipse.jface.commands caused by moving JFace to...

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.4
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	4.4 M1
Assignee:	Hendrik Still
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	411383
	Show dependency tree

Reported:	2013-07-23 05:25 EDT by Hendrik Still
Modified:	2013-08-07 13:56 EDT (History)
CC List:	3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Hendrik Still

2013-07-23 05:25:48 EDT

Fix the compiler warnings in package org.eclipse.jface.commands caused by moving to Java 1.5

Comment 1 Hendrik Still

2013-07-23 05:55:44 EDT

I've uploaded a patch to gerrit:

https://git.eclipse.org/r/#/c/14771/

I also did a small cleanup

Comment 2 John Arthorne

2013-07-23 10:09:22 EDT

(In reply to comment #1)
> I've uploaded a patch to gerrit:
> 
> https://git.eclipse.org/r/#/c/14771/
> 
> I also did a small cleanup

Reviewed and pushed! Keep them coming...

Comment 3 Hendrik Still

2013-07-23 10:14:19 EDT

Thanks, next one is in the pipeline. Without "small cleanup"

Comment 4 Paul Webster

2013-07-23 10:32:00 EDT

Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=99752661ac8adda3c3f0569fdccade307d13f51a

PW

Comment 5 John Arthorne

2013-07-23 10:42:59 EDT

Still ongoing

Comment 6 Lars Vogel

2013-07-23 11:01:07 EDT

@John, I think the org.eclipse.jface.commands package is fixed. I suggested to Hendrik to provide Gerrit reviews per package so that the classes to be reviewed are small. I hope this allows the team to do the review efficient, e.g. in a few minutes while Hendrik can already work on the next package.

Comment 7 Hendrik Still

2013-07-23 11:11:38 EDT

I would also prefere, to have one review/bug per package.

Comment 8 John Arthorne

2013-07-23 11:22:51 EDT

Ok marking fixed.

Comment 9 Paul Webster

2013-08-07 13:56:17 EDT

In 4.4.0.I20130806-2000

PW