This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 413431 - Contact demo update to use dependency injection for MApplication in processors
Summary: Contact demo update to use dependency injection for MApplication in processors
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 M2   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-22 06:31 EDT by Lars Vogel CLA
Modified: 2013-09-17 13:54 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2013-07-22 06:31:20 EDT 

    


    


      



        
          Comment 1
        

        
          Lars Vogel CLA

        

        
        

        
          2013-07-22 06:34:58 EDT
        

      






https://git.eclipse.org/r/14740

    


    


      



        
          Comment 2
        

        
          Lars Vogel CLA

        

        
        

        
          2013-07-23 15:26:49 EDT
        

      






Patch set updated to remove dependency on abandoned commit. Now it depends on master

    


    


      



        
          Comment 3
        

        
          Paul Webster CLA

        

        
        

        
          2013-07-24 15:09:20 EDT
        

      






The patch looks good, but I have a question.  If the superclass has an @Execute as well, is there a chance that it will find the wrong one since it simply picks the first Method it finds that has the annotation @Execute?

Or does reflection work correctly such that if you execute AbstractThemeProcessor.process(*) it will pick MenuThemeProcessor.process(*)?

PW

    


    


      



        
          Comment 4
        

        
          Lars Vogel CLA

        

        
        

        
          2013-07-24 15:47:25 EDT
        

      






The super methods annotated with @Execute is ignored by reflection, so this works fine. 

But I agree that this setup is confusing, I uploaded a new patch set for review which does not use inheritance for the super method.

    


    

    


      



        
          Comment 6
        

        
          Paul Webster CLA

        

        
        

        
          2013-09-17 13:54:38 EDT
        

      






In 4.4.0.I20130916-2330

PW