This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 413348 - [CSS] Stream leaks in AbstractCSSEngine
Summary: [CSS] Stream leaks in AbstractCSSEngine
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M3   Edit
Assignee: Daniel Rolka CLA
QA Contact: Daniel Rolka CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-19 12:53 EDT by Mickael Istria CLA
Modified: 2013-10-29 09:55 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2013-07-19 12:53:30 EDT 
Looking at code of AbstractCSSEngine, we can read several lines opening and manipulating Streams, but not a single .close() methods.
It looks like there is a stream leak in that class.
Comment 1 Mickael Istria CLA 2013-07-19 12:55:58 EDT 
Suggested change: https://git.eclipse.org/r/14712
It also contains many style changes (shouldn't affect behaviour). The interesting part can be found while searching for .close()
Comment 2 Paul Webster CLA 2013-07-23 11:35:38 EDT 
I've added comments to the Gerrit patch.

Basically that's a large formatting change I don't want to submit, plus it added this. in front of a bunch of fields and we don't do that.

PW
Comment 3 Mickael Istria CLA 2013-10-22 10:51:11 EDT 
The suggested change was merged. I guess if can be marked as resolved for 4.4.M3
Comment 4 Daniel Rolka CLA 2013-10-29 09:55:14 EDT 
Verified in the build: I20131028-2000