Community
Participate
Working Groups
Using Eclipse 4.3 (Linux, Mac) or 4.4 I20130717-1600 (Linux) 1. Open 2 files in two editors side by side 2. Ctrl+E in the left editor, Quick switch appears at the top of the left editor. 3. Ctrl+E in the right editor. Quick switch still appears at the top of the left editor. This is a regression compared to 3.8.
Proposed fix: https://git.eclipse.org/r/14748
Eric, could you please review this? PW
Marc, I think I must be confused...the patch appears to be dead code to me; when I put a breakpoint on it and do Ctrl + Shft + E it never fires and I see no difference between what happens before or after the switch... Also, doing the same thing in 3.8 also gets me a dialog that doesn't change position based on where the active editor is. Could you attach a screen shot of what the editor switcher looks like to you ? Even better would be another showing how it's different in 3.8. Also look in the Keys preference page and tell me what command Ctrl + Shft + E is bound to. Note there's a WorkbenchEditorsHandler (as opposed to the WorkbookEditorsHandler that seems to be what you wanted (at least it's what gets invoked by my Ctrl E...).
(In reply to comment #3) > Marc, I think I must be confused... I think you've been looking at Switch to Editor which is different from Quick Switch Editor.
Created attachment 233724 [details] Keybindings
Created attachment 233725 [details] Eclipse 3.8 screenshot
Created attachment 233726 [details] Eclipse 4.3.0 screenshot The right editor has focus. Notice how the left editor gets the menu.
Yes, my bad...sorry. I can now find the right code. I think I can see part of the issue from the screen cap. I suspect that you've managed to drag the right stack *out* of the area. This isn't generally possible unless you hold down the Ctrl key so I'm not sure how you got there (perhaps you were using an earlier (4.2 workspace and had already done this ?). I can tell because when the editor area is split in 4.x it generates an 'area' affordance containing the min / max buttons and removes them from the inner tab folders... When you hit Ctrl M to maximize how many stacks do you see ?
OK, now I see how this differs from the original code. The current code (erroneously) expects that the currently active editor is in a stack in the editor area while your code just gets the parent stack of the active editor wherever it is... Thanks, the new code is much better. It does have an interesting side-effect; if you put an editor into a stack with views in it and make it active then Ctrl+e will show you both the views and the editor and let you switch between them, fine by me...;-).
Committed http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=15e344c5935f2347ba8920330ced762e34461b95 Thanks again Marc !
Created attachment 233735 [details] Wasted space Thanks Eric! I am pleasantly surprised by how quick this was resolved. (In reply to comment #8) > Yes, my bad...sorry. I can now find the right code. I think I can see part > of the issue from the screen cap. I suspect that you've managed to drag the > right stack *out* of the area. This isn't generally possible unless you hold > down the Ctrl key so I'm not sure how you got there (perhaps you were using > an earlier (4.2 workspace and had already done this ?). I can tell because > when the editor area is split in 4.x it generates an 'area' affordance > containing the min / max buttons and removes them from the inner tab > folders... I always drag it out of the area because the 'area' it generates just wastes space. So is this a bug that I can just drag it out without holding Ctrl? Should I create a new bug for that?
Interesting, let's hold off on opening a defect against the fact that you can split a non-editorarea stack with one from the editor area. I didn't realize that this was possible (and I wrote the code..;-) but it doesn't seem to have been causing major hassles for our users AFAIK. I'll run the scenario by the folks here and we'll open a defect if necessary, thanks again for your work on this.
Verified in the build: I20130805-2000
