This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 413167 - Make Quick Access smaller
Summary: Make Quick Access smaller
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M2   Edit
Assignee: Daniel Rolka CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-17 10:18 EDT by John Arthorne CLA
Modified: 2013-09-17 05:10 EDT (History)
3 users (show)

See Also:


Attachments
Fixed search field (5.35 KB, image/png)
2013-07-18 03:36 EDT, Daniel Rolka CLA
no flags Details
Fixed search field - updated (4.55 KB, image/png)
2013-07-22 04:25 EDT, Daniel Rolka CLA
no flags Details
Demonstrates the ugly white corner around the search box (1.49 KB, image/png)
2013-08-19 11:15 EDT, Lars Vogel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2013-07-17 10:18:39 EDT
Creating a new bug to avoid the swirl in bug 362420.

I think we can afford to make the Quick Access text area smaller. Once you start typing, all the useful information appears in the dropdown anyway. You rarely need to type more than a couple of characters in the box to find what you want. As long as the box is wide enough to fit the hint words "Quick Access" I think we could afford to cut about a 3rd of its current width.
Comment 1 Paul Webster CLA 2013-07-17 10:20:18 EDT
Daniel, could you please take a look at this?

PW
Comment 2 Daniel Rolka CLA 2013-07-18 03:36:27 EDT
Created attachment 233583 [details]
Fixed search field

The patch proposal has been sent to Gerrit - http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=04d5e53e7e52e92dc423430658324bbe79edf7a9

Please take a look on the attachment to see how it works

Daniel
Comment 3 Curtis Windatt CLA 2013-07-18 14:16:48 EDT
Has this been tested in Linux?  On Win7 the text just barely fits.

Also, having it so close the text size gives it the appearance of a button with a white background rather than a text box.  Since it is the only textbox in the toolbar/statusbar it doesn't look right.
Comment 4 John Arthorne CLA 2013-07-20 08:15:18 EDT
Yes it would look better with a little more space than that.
Comment 5 Daniel Rolka CLA 2013-07-22 04:25:39 EDT
Created attachment 233660 [details]
Fixed search field - updated

I've sent another patch to Gerrit that modifies the width of the search field according to the comments above

Unfortunately I'm not able to test it on Linux

Daniel
Comment 6 Paul Webster CLA 2013-07-23 11:50:34 EDT
https://git.eclipse.org/r/#/c/14641/

On Linux the bug becomes short and the text is clipped at the ...Acc

My guess is that width hint needs to be calculated some way from the current font.  I've seen FontMetrics used before: http://www.java2s.com/Tutorial/Java/0300__SWT-2D-Graphics/UsingFontMetricstogetcharwidth.htm

PW
Comment 7 Dani Megert CLA 2013-08-09 04:03:55 EDT
Moving to M2 as per bug 414630 comment 4.
Comment 8 Daniel Rolka CLA 2013-08-19 11:07:57 EDT
The updated patch has been sent to Gerrit - http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d0a4fa91f8e4f2badf9bfaf7d358b3873f6fce69

Daniel
Comment 9 Lars Vogel CLA 2013-08-19 11:15:18 EDT
Search box size look look for me on Linux with the updates patch. Any idea how to get rid of the "ugly white border" around the search box? If I remove the SWT.SEARCH style bit, it looses the white box around it but of course it also looses the search flavor.
Comment 10 Lars Vogel CLA 2013-08-19 11:15:58 EDT
Created attachment 234537 [details]
Demonstrates the ugly white corner around the search box
Comment 11 Lars Vogel CLA 2013-08-19 11:17:46 EDT
Gerrit review URL for the change from Daniel: https://git.eclipse.org/r/#/c/14641/
Comment 13 Daniel Rolka CLA 2013-09-17 05:10:37 EDT
Verified in the build: I20130916-2330