Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 412977 - Include a link instead of a patch on CQs for contributions received via Gerrit
Summary: Include a link instead of a patch on CQs for contributions received via Gerrit
Status: CLOSED DUPLICATE of bug 408738
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: IPZilla (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eclipse Foundation IPZilla inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks: 435599
  Show dependency tree
 
Reported: 2013-07-15 10:33 EDT by Wayne Beaton CLA
Modified: 2017-07-27 14:53 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wayne Beaton CLA 2013-07-15 10:33:00 EDT
All contributions that require a CQ, must be included as a patch on the CQ for review by the IP Team.

Some committers have asked that we review this policy in light of Gerrit: for contributions that come through Gerrit, the contribution can be viewed online (e.g. [1]).

The main question is, can the IP team work directly from Gerrit? We may need some Gerrit-savvy individuals to help sort out the workflow differences.

Does the IP workflow require a patch file specifically?

Note that we have an evil plan to automate the creation of CQs from Gerrit that may be a better solution for everybody. Bear in mind that we have not investigated the feasibility of providing this functionality.

[1] https://git.eclipse.org/r/#/c/14470/
Comment 1 Wayne Beaton CLA 2013-07-15 10:43:19 EDT
(In reply to comment #0)
> Note that we have an evil plan to automate the creation of CQs from Gerrit
> that may be a better solution for everybody. Bear in mind that we have not
> investigated the feasibility of providing this functionality.

See Bug 412980.
Comment 2 Janet Campbell CLA 2013-07-25 15:58:38 EDT
(In reply to comment #0)

> Does the IP workflow require a patch file specifically?

IP workflow requires that the related code be attached to the IPBug so that an automatic scan of the code is performed.  Those scan results are then used during the due diligence review.
Comment 3 Eclipse Genie CLA 2017-01-30 15:32:31 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 4 Wayne Beaton CLA 2017-07-27 14:53:03 EDT
(In reply to Janet Campbell from comment #2)
> IP workflow requires that the related code be attached to the IPBug so that
> an automatic scan of the code is performed.  Those scan results are then
> used during the due diligence review.

This is an implementation detail that is no longer valid.

More generally, however, I believe that there is actual value in attaching the contribution to the CQ as it provides us with a very durable record of the exact contribution. While Git repos are generally stable, repos can be moved, commits can be merged or rewritten, content can be moved from one repository to another, etc.

I think that this might actually be a duplicate of Bug 408738 (based on the last paragraph of the problem statement) so I'm marking it as such.

*** This bug has been marked as a duplicate of bug 408738 ***