Comment 1 Miles Parker 2013-07-15 20:27:14 EDT

LOL. That summary took me a minute to decipher.

Comment 2 Tomasz Zarna 2013-08-22 05:38:10 EDT

CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=7565

Comment 3 Steffen Pingel 2013-09-04 13:11:25 EDT

The CQ was approved! Let's go for this.

Comment 4 Tomasz Zarna 2013-09-10 08:19:14 EDT

Review: https://git.eclipse.org/r/#/c/16283/

Comment 5 Steffen Pingel 2013-09-10 11:53:39 EDT

Nice! Posted a screenshot here: https://bugs.eclipse.org/bugs/attachment.cgi?id=235358. Let's do a quick review during tomorrow's call.

Comment 6 Tomasz Zarna 2013-09-11 11:28:20 EDT

Created attachment 235392 [details]
Diffy's head

Comment 7 Tomasz Zarna 2013-09-11 11:31:31 EDT

(In reply to Tomasz Zarna from comment #6)
> Diffy's head

IMO this looks better, still requires some pixels to be moved around, but at least it bears a resemblance to Diffy.

Comment 8 Tomasz Zarna 2013-09-12 05:00:37 EDT

Created attachment 235416 [details]
Diffy in the wild

Both icons as in https://git.eclipse.org/r/#/c/16283/2

Comment 9 Thomas Ehrnhoefer 2013-09-12 08:08:40 EDT

Hope that change doesn't introduce too many regressions. I like the choice of using a partial headshot, looks good.

Comment 10 Steffen Pingel 2013-09-15 06:19:55 EDT

We also need to update the 32x32 gerrit32.png icon in the org.eclipse.mylyn.discovery-directory bundle.

Comment 11 Tomasz Zarna 2013-09-20 06:13:33 EDT

(In reply to comment #10)
> We also need to update the 32x32 gerrit32.png icon in the
> org.eclipse.mylyn.discovery-directory bundle.

Review for that: https://git.eclipse.org/r/#/c/16634/

Comment 12 Tomasz Zarna 2013-09-20 06:34:59 EDT

Created attachment 235656 [details]
Tuning

Is this any better? https://git.eclipse.org/r/#/c/16283/2 on the left, the tuned icon from my workspace on the right.

Comment 13 Steffen Pingel 2013-09-23 05:17:01 EDT

Thanks! I merged the discovery change. I like the tuned icons slightly better. Please feel free to merge!

Comment 14 Tomasz Zarna 2013-09-23 06:13:50 EDT

Merged as f14dc2c3163be54c501ff4ed200b95535b52e8b9

Comment 15 Robin Stocker 2013-12-04 06:45:18 EST

Hey guys. Since this change, EGit and Mylyn no longer use the same icon for Gerrit, see bug 423138. EGit shows the icon in the Git Repositories view in case a repository is configured for Gerrit.

Tomasz, as you're also an EGit committer, would it be possible for you take a look at this on the EGit side?

By the way, the favicon of https://gerrit-review.googlesource.com/ is still the old icon, so I'm not sure which one is more recognizable, the +/- one or Diffy the Kung Fu Review Cuckoo:).

Comment 16 Tomasz Zarna 2014-01-02 12:37:15 EST

(In reply to Robin Stocker from comment #15)
 
> Tomasz, as you're also an EGit committer, would it be possible for you take
> a look at this on the EGit side?

Sure, here's a review with updated icons: https://git.eclipse.org/r/#/c/20222/
 
> By the way, the favicon of https://gerrit-review.googlesource.com/ is still
> the old icon, 

I think they simply forgot to update it.

>so I'm not sure which one is more recognizable, the +/- one or
> Diffy the Kung Fu Review Cuckoo:).

I'm sure that once both projects start to show Diffy, everyone is going to forgot about the +/- pretty soon.

Comment 17 Robin Stocker 2014-04-20 12:11:19 EDT

(In reply to Tomasz Zarna from comment #16)
> (In reply to Robin Stocker from comment #15)
> > By the way, the favicon of https://gerrit-review.googlesource.com/ is still
> > the old icon, 
> 
> I think they simply forgot to update it.

I filed a bug for this: https://code.google.com/p/gerrit/issues/detail?id=2614