Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 412285 - 'Show In' menu of view in detached window has 'No Applicable Views'
Summary: 'Show In' menu of view in detached window has 'No Applicable Views'
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M3   Edit
Assignee: Piotr Aniola CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 435284
  Show dependency tree
 
Reported: 2013-07-04 06:05 EDT by Kevin Milburn CLA
Modified: 2014-05-20 09:15 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Milburn CLA 2013-07-04 06:05:38 EDT 
With the Git Repositories View within the main Eclipse window the 'Show In' context menu contains several views (History, Properties, etc.).

When the Git Repositories View is detached from the main window, all instances of the 'Show In' context menu contain '<No Applicable Views>'.
Comment 1 Robin Stocker CLA 2013-07-04 06:59:38 EDT 
I could also reproduce this when detaching the Outline view, so it's a problem in Eclipse Platform UI (Workbench), not in EGit -> changed product.

Eclipse 4.3.0, Eclipse Workbench 3.105.0.v20130529-1406
Comment 2 Eric Moffatt CLA 2013-07-09 14:16:03 EDT 
Good one ! I can trivially repro this on windows using the Package Explorer.

Paul, perhaps we have some logic that relies on being able to traverse up to the main window using 'getParent' (which will fail for DW contained views) ?
Comment 3 Piotr Aniola CLA 2013-10-07 10:59:56 EDT 
Gerrit link for review:
https://git.eclipse.org/r/17112

org.eclipse.ui.internal.ShowInMenu.getSourcePart() did not work for detached windows.
Comment 4 Dani Megert CLA 2013-10-08 04:18:30 EDT 
(In reply to Piotr Aniola from comment #3)
> Gerrit link for review:
> https://git.eclipse.org/r/17112
> 
> org.eclipse.ui.internal.ShowInMenu.getSourcePart() did not work for detached
> windows.

Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=04f909bf76c151865e4647a514bb53846db4be6f

Removed superfluous 'null' check with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2b27206f669049c2bc430a71a09b4e6578c80176
Comment 5 Paul Webster CLA 2013-10-29 14:18:34 EDT 
in 4.4.0.I20131028-2000

PW
Comment 6 Dani Megert CLA 2014-05-20 09:15:06 EDT 
This caused a regression, see bug 435284.