Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 412013 - Secondary Problems view (created with 4.2) doesn't have a view menu
Summary: Secondary Problems view (created with 4.2) doesn't have a view menu
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-01 10:48 EDT by Markus Keller CLA
Modified: 2016-09-02 14:48 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2013-07-01 10:48:44 EDT
Follow-up to bug 401709.

With 4.2.2, create a secondary Problems view.
=> Has no view menu (bug 401709).

Start the same workspace with 4.3.
=> Secondary Problems view still doesn't have a view menu.

Workaround: Create a third Problems view to get the view menu back. The second Problems view never gets a view menu any more, even if I reset the perspective or try it in another perspective.

[Did I already mention it's a bad idea to store model information that would better be re-generated from scratch on startup?]
Comment 1 Eric Moffatt CLA 2013-07-09 15:31:26 EDT
Markus, this isn't a question of where the info is stored but how it's defined...the early pass at the implementation used a different technique to identify the 'id' of the view. 

I'm not sure how we could 're-generate' the ids on startup; even in 3.x they were captured as part of that view's id...

If you close the one without a menu and open an new one does everything go back to working ?
Comment 2 Markus Keller CLA 2013-07-10 13:08:30 EDT
> If you close the one without a menu and open an new one does everything go
> back to working ?

No, and that's my reason for not categorizing this as minor. Once the workspace is in that state, the second Problems view is always created without a view menu. I would expect that closing a secondary view also removes all metadata for that view.
Comment 3 Eric Moffatt CLA 2013-07-11 16:02:51 EDT
Unfortunately (in this case) closing a view doesn't remove it from the model but leaves the placeholder and associated part in the model (so it'll re-open where it last was).

I'm pretty sure that very few people will have instances of secondary views in their workspace from before the id change handling went in since they basically didn't work at all until then.

I still have some old installs around so I'll at least check to see if the fix is trivial...
Comment 4 Eric Moffatt CLA 2014-02-04 13:59:27 EST
Markus, so you still think that this is important (critical) for Luna ? I don't know of any other defects reported from folks facing this issue so my guess is that its overall impact is minimal.

If you agree I'll move this off of our Luna plate...
Comment 5 Markus Keller CLA 2014-02-19 05:48:17 EST
(In reply to Eric Moffatt from comment #3)
> Unfortunately (in this case) closing a view doesn't remove it from the model
> but leaves the placeholder and associated part in the model (so it'll
> re-open where it last was).

Thanks, that's helpful information. Knowing this, I found a

=> Workaround: Open a new window and then close the bad window. <=

> I'm pretty sure that very few people will have instances of secondary views
> in their workspace from before the id change handling went in since they
> basically didn't work at all until then.

The problem is that the bug doesn't go away when you close the secondary view, so people who once ran into this with 4.2 will never recover from the bug. At least Reset Perspective should also remove the placeholders.

(In reply to Eric Moffatt from comment #4)
> I
> don't know of any other defects reported from folks facing this issue so my
> guess is that its overall impact is minimal.

Maybe the absence of other reports is because people don't know how to reproduce, and therefore don't think filing a bug will actually help?

But I agree it's not critical any more, now that we have a workaround.
Comment 6 Lars Vogel CLA 2015-02-04 05:51:27 EST
Tested in 4.5.0.I20150129-1830 and works for me.

1.) Select Problems view menu "New Rroblems view"
2.) New Problems view has menu
3.) Restart IDE -> still has its menu

Marking as fixed.
Comment 7 Dani Megert CLA 2015-02-04 10:02:35 EST
(In reply to Lars Vogel from comment #6)
> Tested in 4.5.0.I20150129-1830 and works for me.
> 
> 1.) Select Problems view menu "New Rroblems view"
> 2.) New Problems view has menu
> 3.) Restart IDE -> still has its menu
> 
> Marking as fixed.

This is not the test case for this bug (see summary or comment 0).
Comment 8 Lars Vogel CLA 2016-09-02 14:48:56 EDT
I don't think anyone will work on this. Workaround is to close the problems view create with 4.2 and reopen it.