Community
Participate
Working Groups
Steps to reproduce the issue: - open java editor - press CTRL-O to view inplace outline - press CTRL-Q ==> eclipse is surpisingly closed CTRL-Q keyboard shortcut for java editor triggers a "Jump to last modification". The workbench should not be closed if I press CTRL-Q if the inplace outline view is open. Class org.eclipse.e4.ui.internal.workbench.ExitHandler is internally called. Is this really the intended behavior? With best regards, Tobias Melcher
This is critical, since you don't even get a chance to save dirty editors.
This happens in all dialogs (e.g. in About Eclipse). See also bug 412001.
Yoiks !! Not sure why Ctrl-Q is firing the e4.Exit command, this command doesn't show up in the Keys pref page (I unbound the 'Last Edit Location'. Paul Elder just pointed out the likely cause...the 'e4.exit' command is bound to Ctrl-Q...in the legacyIDE.xmi file !! We should take a very close look at both this and any other bindings declared in the startup model...
Command+Q means Quit on the Mac, where M1 is Command. But that shouldn't affect Windows.
I've released a fix for the quit problem. http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8f2a2860a007b7321d03dcae23bb10941a12ffea http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=c6f76d3ee70c56b52aa17b2e0db2e8cbbab219be Those e4 commands should never be defined in the IDE. They're a leftover from when we were originally defining the Workbench model. I'll leave this bug open as we still need a fix for the fact that window keybindings are restricted when a dialog has the focus. PW
The fixes in comment 5 only affects new workspaces. Any workspace created before the fix will still have these commands saved in <workspaceroot>/.metadata/.plugins/org.eclipse.e4.workbench/workbench.xmi To correct existing workspaces, we'd need to scrub these commands from workbench.xmi
(In reply to comment #6) > To correct existing workspaces, we'd need to scrub these commands from > workbench.xmi Maybe related to bug 405296?
(In reply to comment #6) > > To correct existing workspaces, we'd need to scrub these commands from > workbench.xmi I've created a processor that will scrub the old e4 commands out of a workbench based RCP project: https://git.eclipse.org/r/#/c/15021/ Paul, could you please have a look? PW
Changes from comment 8 released to master as https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1502559fa72c7786159fc0cd7fb626b4b09149a5
(In reply to comment #7) > > Maybe related to bug 405296? Not really. In this case, we had incorrectly put some information in the prototypical workbench.xmi, and we needed to remove it. In bug 405296, the situation is much more complex. We've had a contribution, which we've integrated into the model via model processors. Then the contributor has disappeared. I imagine the 'correct' thing to do is some of these cases is remove those contributions. But in cases where views or editors have been contributed, it seems best to leave things, and let the user remove them if they don't want them.
Verified that it works in I20130807-2000.
*** Bug 431887 has been marked as a duplicate of this bug. ***
*** Bug 392860 has been marked as a duplicate of this bug. ***
