Community
Participate
Working Groups
Created attachment 232679 [details] log showing "gtk errors" while using search dialog I tried using export SWT_GTK3=1 for a while, but found that "global file search" does not work well with that enabled. It works the first time, but subsequent searches searches with same options, no matter what I try. Will work (once) again, if I restart Eclipse. Details, Select package explorer, then Search (with "File" dialogue ... haven't tried other types). Fill in something like "antrun" and search through all "pom.xml" in workspace. Click 'Search' button, the dialog goes away, and matching files are displayed as expected. Now, try a section time, say search for "abc" in any file, click 'Search'. First notice the Search Dialog does not go away (is not dismissed, or closed) and the original "antrun" search (on pom.xml files) is redisplayed (you can see search results being refreshed, as though repeating the search, but with old values). Log has "gtk" errors in it related to "tree items" ... hence might be related to other GTK3 bugs ... hard to tell.
Just tested with 4.3 RC4 and was able to reproduce the bug with the exact same stack trace in the log... will try to debug.
*** Bug 408266 has been marked as a duplicate of this bug. ***
Created attachment 234461 [details] Proposed fix
The proposed fix disconnects the model from the view which seems to fix the problem. It also seems to cause no troubles on gtk 2.x so I would rather not guard it for gtk 3.x unless needed.
The fix looks fine. Is it necessary on Table.removeAll() as well?
(In reply to comment #5) > The fix looks fine. Is it necessary on Table.removeAll() as well? I don't think so because Table doesn't rely on gtk_tree_model_get to retrieve the index while Tree does and that's where things are going out of sync.
Fixed in http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=b2711372e321f1d46148c930a5bd50d663263ba4
Mark as fixed.