Community
Participate
Working Groups
Extracted from Bug 409588
https://github.com/gabrielluong/orion.client/commit/17093f4f4492139be01d06800b8e74f59c0b0c88 Notes 1. The former implementation would overwrite the parent node with innerHTML and did not make use of the <button>. 2. An implementation decision was to make the class only good at making dropdown menu. In this case, making the dropdown menu div and add its content into the it. This dropdown menu div would then be appended to a parent node and triggered by a node that is specified by the params in the constructor. The class should not have to worry about creating the trigger node or the parent node. 3. Allows for easier styling of the trigger nodes (buttons) as a result of getting rid of (1) 4. [Fixes] Gets rid of the coloured outline around the dropdown menu container. 5. Cleaner dom in the banner. Got rid of the navigation label and arrows that weren't used. 6. The former panel param wasn't really necessary, and it was questionable if that really did anything. 7. [Fixes] Good news! You can now close the dropdown menu by clicking on the button. 8. [Fixes] Added hover to the wrench button I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL
Seems like a good cleanup, pushed http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f087afb
